Bug 1622690
| Summary: | Review Request: nodejs-irc-upd - NodeJS IRC client library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Rosser <rosser.bjr> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-09-21 05:24:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1622689 | ||
| Bug Blocks: | 1622694 | ||
|
Description
Ben Rosser
2018-08-27 18:20:32 UTC
Add dependency on nodejs-chardet. - Remove the executable bits of these files and fix the line encodings: nodejs-irc-upd.noarch: W: spurious-executable-perm /usr/share/doc/nodejs-irc-upd/CHANGELOG.md nodejs-irc-upd.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/nodejs-irc-upd/CHANGELOG.md nodejs-irc-upd.noarch: W: spurious-executable-perm /usr/share/doc/nodejs-irc-upd/README.md nodejs-irc-upd.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/nodejs-irc-upd/README.md nodejs-irc-upd.noarch: W: spurious-executable-perm /usr/share/doc/nodejs-irc-upd/docs/API.rst nodejs-irc-upd.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/nodejs-irc-upd/docs/API.rst nodejs-irc-upd.noarch: W: spurious-executable-perm /usr/share/doc/nodejs-irc-upd/docs/conf.py nodejs-irc-upd.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/nodejs-irc-upd/docs/conf.py nodejs-irc-upd.noarch: E: wrong-script-interpreter /usr/share/doc/nodejs-irc-upd/example/bot.js /usr/bin/env node nodejs-irc-upd.noarch: E: wrong-script-interpreter /usr/share/doc/nodejs-irc-upd/example/secure.js /usr/bin/env node - License ok - Latest version packaged - Builds in mock - Conforms to Packaging Guidelines Spec URL: https://tc01.fedorapeople.org/nodejs/discord-irc/nodejs-irc-upd.spec SRPM URL: https://tc01.fedorapeople.org/nodejs/discord-irc/nodejs-irc-upd-0.10.0-2.fc28.src.rpm I've removed the line endings and executable bits from the documentation files. rpm still complains about wrong-script-interpreter in the doc directory, but the files aren't executable, so I don't believe it matters. If you think it should be fixed, though, I will do so. Ok, package approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-irc-upd nodejs-irc-upd-0.10.0-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-334cbfefe8 nodejs-irc-upd-0.10.0-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-334cbfefe8 nodejs-irc-upd-0.10.0-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |