Bug 1622690 - Review Request: nodejs-irc-upd - NodeJS IRC client library
Summary: Review Request: nodejs-irc-upd - NodeJS IRC client library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1622689
Blocks: 1622694
TreeView+ depends on / blocked
 
Reported: 2018-08-27 18:20 UTC by Ben Rosser
Modified: 2018-09-21 05:24 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-09-21 05:24:46 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Ben Rosser 2018-08-27 18:20:32 UTC
Spec URL: https://tc01.fedorapeople.org/nodejs/discord-irc/nodejs-irc-upd.spec
SRPM URL: https://tc01.fedorapeople.org/nodejs/discord-irc/nodejs-irc-upd-0.10.0-1.fc28.src.rpm

Description:
node-irc is an IRC client library written in JavaScript for Node.

Fedora Account System Username: tc01

Comment 1 Ben Rosser 2018-08-27 18:21:18 UTC
Add dependency on nodejs-chardet.

Comment 2 Robert-André Mauchin 🐧 2018-08-27 20:35:45 UTC
 - Remove the executable bits of these files and fix the line encodings:

nodejs-irc-upd.noarch: W: spurious-executable-perm /usr/share/doc/nodejs-irc-upd/CHANGELOG.md
nodejs-irc-upd.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/nodejs-irc-upd/CHANGELOG.md
nodejs-irc-upd.noarch: W: spurious-executable-perm /usr/share/doc/nodejs-irc-upd/README.md
nodejs-irc-upd.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/nodejs-irc-upd/README.md
nodejs-irc-upd.noarch: W: spurious-executable-perm /usr/share/doc/nodejs-irc-upd/docs/API.rst
nodejs-irc-upd.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/nodejs-irc-upd/docs/API.rst
nodejs-irc-upd.noarch: W: spurious-executable-perm /usr/share/doc/nodejs-irc-upd/docs/conf.py
nodejs-irc-upd.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/nodejs-irc-upd/docs/conf.py
nodejs-irc-upd.noarch: E: wrong-script-interpreter /usr/share/doc/nodejs-irc-upd/example/bot.js /usr/bin/env node
nodejs-irc-upd.noarch: E: wrong-script-interpreter /usr/share/doc/nodejs-irc-upd/example/secure.js /usr/bin/env node


 - License ok
 - Latest version packaged
 - Builds in mock
 - Conforms to Packaging Guidelines

Comment 3 Ben Rosser 2018-08-29 20:22:27 UTC
Spec URL: https://tc01.fedorapeople.org/nodejs/discord-irc/nodejs-irc-upd.spec
SRPM URL: https://tc01.fedorapeople.org/nodejs/discord-irc/nodejs-irc-upd-0.10.0-2.fc28.src.rpm

I've removed the line endings and executable bits from the documentation files.

rpm still complains about wrong-script-interpreter in the doc directory, but the files aren't executable, so I don't believe it matters. If you think it should be fixed, though, I will do so.

Comment 4 Robert-André Mauchin 🐧 2018-08-30 19:28:35 UTC
Ok, package approved.

Comment 5 Gwyn Ciesla 2018-08-30 19:47:21 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-irc-upd

Comment 6 Fedora Update System 2018-08-30 20:31:12 UTC
nodejs-irc-upd-0.10.0-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-334cbfefe8

Comment 7 Fedora Update System 2018-08-31 16:22:32 UTC
nodejs-irc-upd-0.10.0-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-334cbfefe8

Comment 8 Fedora Update System 2018-09-21 05:24:46 UTC
nodejs-irc-upd-0.10.0-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.