Bug 1624701
| Summary: | error-out {inode,entry}lk fops with all-zero lk-owner | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Pranith Kumar K <pkarampu> |
| Component: | locks | Assignee: | bugs <bugs> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | mainline | CC: | bugs |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-04-26 06:52:06 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
REVIEW: https://review.gluster.org/21058 (features/locks: error-out {inode,entry}lk fops with all-zero lk-owner) posted (#1) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22469 (cluster/afr: Send inodelk/entrylk with non-zero lk-owner) posted (#1) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22469 (cluster/afr: Send inodelk/entrylk with non-zero lk-owner) merged (#3) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/21058 (features/locks: error-out {inode,entry}lk fops with all-zero lk-owner) merged (#5) on master by Krutika Dhananjay REVIEW: https://review.gluster.org/22581 (Revert \"features/locks: error-out {inode,entry}lk fops with all-zero lk-owner\") posted (#2) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/22582 (features/sdfs: Assign unique lk-owner for entrylk fop) posted (#1) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22581 (Revert \"features/locks: error-out {inode,entry}lk fops with all-zero lk-owner\") merged (#3) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22586 (cluster/afr: Set lk-owner before inodelk/entrylk/lk) posted (#1) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22586 (cluster/afr: Set lk-owner before inodelk/entrylk/lk) merged (#3) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22582 (features/sdfs: Assign unique lk-owner for entrylk fop) merged (#3) on master by Raghavendra G REVIEW: https://review.gluster.org/22604 (features/locks: error-out {inode,entry}lk fops with all-zero lk-owner) posted (#1) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22604 (features/locks: error-out {inode,entry}lk fops with all-zero lk-owner) merged (#2) on master by Amar Tumballi |
Description of problem: Problem: Sometimes we find that developers forget to assign lk-owner for an inodelk/entrylk/lk before writing code to wind these fops. locks xlator at the moment allows this operation. This leads to multiple threads in the same client being able to get locks on the inode because lk-owner is same and transport is same. So isolation with locks can't be achieved. Fix: Disallow locks with lk-owner zero. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: