Bug 1624701 - error-out {inode,entry}lk fops with all-zero lk-owner
Summary: error-out {inode,entry}lk fops with all-zero lk-owner
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: locks
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-03 06:22 UTC by Pranith Kumar K
Modified: 2019-04-26 06:52 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-04-26 06:52:06 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 21058 0 None Merged features/locks: error-out {inode,entry}lk fops with all-zero lk-owner 2019-04-16 07:08:53 UTC
Gluster.org Gerrit 22469 0 None Open cluster/afr: Send inodelk/entrylk with non-zero lk-owner 2019-04-02 12:19:18 UTC
Gluster.org Gerrit 22581 0 None Open Revert \"features/locks: error-out {inode,entry}lk fops with all-zero lk-owner\" 2019-04-17 08:18:10 UTC
Gluster.org Gerrit 22582 0 None Open features/sdfs: Assign unique lk-owner for entrylk fop 2019-04-22 14:04:11 UTC
Gluster.org Gerrit 22586 0 None Open cluster/afr: Set lk-owner before inodelk/entrylk/lk 2019-04-22 08:47:33 UTC
Gluster.org Gerrit 22604 0 None Merged features/locks: error-out {inode,entry}lk fops with all-zero lk-owner 2019-04-26 06:52:04 UTC

Description Pranith Kumar K 2018-09-03 06:22:25 UTC 
Description of problem:
    Problem:
    Sometimes we find that developers forget to assign lk-owner for an
    inodelk/entrylk/lk before writing code to wind these fops. locks
    xlator at the moment allows this operation. This leads to multiple
    threads in the same client being able to get locks on the inode
    because lk-owner is same and transport is same. So isolation
    with locks can't be achieved.
    
    Fix:
    Disallow locks with lk-owner zero.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Worker Ant 2018-09-03 06:23:32 UTC 
REVIEW: https://review.gluster.org/21058 (features/locks: error-out {inode,entry}lk fops with all-zero lk-owner) posted (#1) for review on master by Pranith Kumar Karampuri
Comment 2 Worker Ant 2019-04-01 10:13:42 UTC 
REVIEW: https://review.gluster.org/22469 (cluster/afr: Send inodelk/entrylk with non-zero lk-owner) posted (#1) for review on master by Pranith Kumar Karampuri
Comment 3 Worker Ant 2019-04-02 12:19:19 UTC 
REVIEW: https://review.gluster.org/22469 (cluster/afr: Send inodelk/entrylk with non-zero lk-owner) merged (#3) on master by Pranith Kumar Karampuri
Comment 4 Worker Ant 2019-04-16 07:08:54 UTC 
REVIEW: https://review.gluster.org/21058 (features/locks: error-out {inode,entry}lk fops with all-zero lk-owner) merged (#5) on master by Krutika Dhananjay
Comment 5 Worker Ant 2019-04-16 17:07:08 UTC 
REVIEW: https://review.gluster.org/22581 (Revert \"features/locks: error-out {inode,entry}lk fops with all-zero lk-owner\") posted (#2) for review on master by Atin Mukherjee
Comment 6 Worker Ant 2019-04-16 19:02:11 UTC 
REVIEW: https://review.gluster.org/22582 (features/sdfs: Assign unique lk-owner for entrylk fop) posted (#1) for review on master by Pranith Kumar Karampuri
Comment 7 Worker Ant 2019-04-17 08:18:12 UTC 
REVIEW: https://review.gluster.org/22581 (Revert \"features/locks: error-out {inode,entry}lk fops with all-zero lk-owner\") merged (#3) on master by Pranith Kumar Karampuri
Comment 8 Worker Ant 2019-04-17 09:01:37 UTC 
REVIEW: https://review.gluster.org/22586 (cluster/afr: Set lk-owner before inodelk/entrylk/lk) posted (#1) for review on master by Pranith Kumar Karampuri
Comment 9 Worker Ant 2019-04-22 08:47:34 UTC 
REVIEW: https://review.gluster.org/22586 (cluster/afr: Set lk-owner before inodelk/entrylk/lk) merged (#3) on master by Pranith Kumar Karampuri
Comment 10 Worker Ant 2019-04-22 14:04:12 UTC 
REVIEW: https://review.gluster.org/22582 (features/sdfs: Assign unique lk-owner for entrylk fop) merged (#3) on master by Raghavendra G
Comment 11 Worker Ant 2019-04-23 06:00:32 UTC 
REVIEW: https://review.gluster.org/22604 (features/locks: error-out {inode,entry}lk fops with all-zero lk-owner) posted (#1) for review on master by Pranith Kumar Karampuri
Comment 12 Worker Ant 2019-04-26 06:52:06 UTC 
REVIEW: https://review.gluster.org/22604 (features/locks: error-out {inode,entry}lk fops with all-zero lk-owner) merged (#2) on master by Amar Tumballi
Note You need to log in before you can comment on or make changes to this bug.