Bug 1627988

Summary: Tendrl Branding changes
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Neha Gupta <negupta>
Component: web-admin-tendrl-uiAssignee: Neha Gupta <negupta>
Status: CLOSED ERRATA QA Contact: Elena Bondarenko <ebondare>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rhgs-3.4CC: ebondare, fbalak, mbukatov, negupta, nthomas, rhs-bugs, sankarshan
Target Milestone: ---Keywords: ZStream
Target Release: RHGS 3.4.z Batch Update 2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tendrl-ui-1.6.3-14.el7rhgs Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-12-17 17:06:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1627651, 1629520    
Bug Blocks:    
Attachments:
Description Flags
About Modal
none
Icon to access about modal
none
About Modal doesn't include username
none
Chromium labeled as Chrome
none
Mistake in Firefox version none

Description Neha Gupta 2018-09-12 04:44:26 UTC
Description of problem:

- Update login view as per the new design - https://www.patternfly.org/pattern-library/application-framework/login-page/

- Add about modal for Tendrl

Comment 2 Neha Gupta 2018-09-19 07:36:12 UTC
*** Bug 1627987 has been marked as a duplicate of this bug. ***

Comment 4 Neha Gupta 2018-10-24 09:55:34 UTC
About Modal will list the following details -

1) Tendrl Version 
2) Logged in User Name
3) Logged in User role
4) Browser name where the application is being viewed and its version
5) Browser's Operating System 

Steps to access it -

1) Login to Tendrl.
2) A new icon has been added at the top on the right hand side.
3) Clicking on this icon will show a modal i.e. About Modal.
4) There one can verify the details, I have mentioned before.

Attaching the screenshot for the 
1) About Modal
2) The new icon added to access it.

Comment 5 Neha Gupta 2018-10-24 09:58:50 UTC
Created attachment 1496957 [details]
About Modal

Comment 6 Neha Gupta 2018-10-24 10:14:05 UTC
Created attachment 1496958 [details]
Icon to access about modal

Comment 7 Martin Bukatovic 2018-10-30 10:33:01 UTC
Providing QA ACK, with the following condition:

Since there may not be enough time to fix and retest WA ui if serious problems
are discovered, we will follow the following *mitigation plan* in such case:
drop changes related to patternfly, branding from BU2 (BZ 1627651, BZ 1627988
and BZ 1629520 - and if that is not possible, drop all ui changes from BU2).

Comment 10 Elena Bondarenko 2018-11-07 14:38:35 UTC
Created attachment 1503015 [details]
About Modal doesn't include username

Comment 11 Elena Bondarenko 2018-11-07 14:40:30 UTC
About Modal doesn't show the username of the logged in user. I've attached the screenshot.

Comment 12 Elena Bondarenko 2018-11-07 14:50:22 UTC
I'm also not sure that "Version 3.4.0" is correct. There was a chapter in WA quick start guide on upgrading WA from version 3.4.x to 3.4.y, and this screenshot was taken from the last version, so it could hardly be 3.4.0.

Maybe it would be better to just have Version 3.4 here so as not to change it every time a batch update comes out.

Comment 14 Elena Bondarenko 2018-11-09 11:21:50 UTC
As far as I can see, there are no other issues.

Comment 15 Filip Balák 2018-11-13 08:02:14 UTC
Created attachment 1505148 [details]
Chromium labeled as Chrome

Comment 16 Filip Balák 2018-11-13 08:03:45 UTC
Chromium is labeled as Chrome in About Modal as shown in attachment 1505148 [details].

Comment 20 Elena Bondarenko 2018-11-21 11:51:20 UTC
Created attachment 1507645 [details]
Mistake in Firefox version

Comment 21 Neha Gupta 2018-11-22 09:50:46 UTC
The issue is with the "ng-device-detector" npm package which is used to display all the device informations. 

The Dev and QE teams have decided not to show the browser version in the about modal as  it doesn't add much value to the user.

Comment 22 Elena Bondarenko 2018-11-27 15:29:36 UTC
The About modal shows correct information.

Comment 23 errata-xmlrpc 2018-12-17 17:06:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:3829