Bug 162825
| Summary: | "Advisory Notes" text can cause python traceback | ||
|---|---|---|---|
| Product: | [Retired] Fedora Infrastructure | Reporter: | Jason Vas Dias <jvdias> |
| Component: | update system | Assignee: | Luke Macken <lmacken> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Bill Nottingham <notting> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | unspecified | CC: | pfrields, rvokal |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-07-08 23:18:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
notes = notes.replace('\'', '\\\'') should do the trick. Thanks for the report.
By the way, you can add (and remove) as many updates as you want in the future,
because the Release Team doesn't hear about it until you click "Submit to
Release Team".
|
Description of problem: The first time I used the new fedora update page to create a dhcp update, I entered some "Advisory Notes" text, and got this python traceback: " Mod_python error: "PythonHandler mod_python.publisher" Traceback (most recent call last): File "/usr/src/build/513032-i386/install/usr/lib/python2.2/site-packages/mod_python/apache.py", line 332, in HandlerDispatch File "/usr/src/build/513032-i386/install/usr/lib/python2.2/site-packages/mod_python/publisher.py", line 199, in handler File "/mnt/redhat/fedora-updates/add.py", line 63, in add_update db.query(query) File "/mnt/redhat/fedora-updates/db.py", line 47, in query db.query(q) _pg.error: ERROR: parser: parse error at or near "headers" at character 705 " I had tried to enter this "Advisory Notes" text : " - Fixes possible network flood on repeated DHCPDECLINE (bugs 159929, 162080) - Removes 1-5 second delay on dhclient startup if only one interface being configured - make dhclient not emit ISC blurb on error exit - dhclient-script fixes: o remove 1 second sleep on PREINIT o further replacement of /sbin/route by /sbin/ip o fix determination of runlevel in init state 1 o add class A,B,C static route support o add ARPCHECK / ARPSEND support o fix bug 151023: dhclient RPM description claimed 'headers and libraries' " Removing all "Advisory Notes" text allowed me to submit the FC3 update ( dhcp-3.0.1-44_FC3 FC3 Final none 2005-07-08 ) On further consideration it appears the quoted string "'headers" could have been the cause of the problem - you should escape single-quotes with a backslash ("\\'") in "Advisory Notes" text before attempting to insert the string in the database. Version-Release number of selected component (if applicable): How reproducible: probably 100% - don't want to raise another fedora update to test :) Steps to Reproduce: 1. Create Fedora Update with "Advisory Notes" text containing "'" quoted string Actual results: Python traceback Expected results: Submitted Fedora update