Bug 1629053

Summary:	remove-args seems unable to handle backslash
Product:	Red Hat Enterprise Linux 7	Reporter:	Qian Cai <qcai>
Component:	grubby	Assignee:	Peter Jones <pjones>
Status:	CLOSED DUPLICATE	QA Contact:	Release Test Team <release-test-team-automation>
Severity:	high	Docs Contact:
Priority:	high
Version:	7.6	CC:	fmartine
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1629054 (view as bug list)		Environment:
Last Closed:	2018-09-17 13:31:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1629054

Description Qian Cai 2018-09-14 18:09:54 UTC

Description of problem:
# cat /proc/cmdline 
BOOT_IMAGE=/vmlinuz-3.10.0-862.14.1.el7.ppc64le root=/dev/mapper/rhel_ibm--p8--storage--02--guest--15-root ro crashkernel=auto rd.lvm.lv=rhel_ibm-p8-storage-02-guest-15/root rd.lvm.lv=rhel_ibm-p8-storage-02-guest-15/swap LANG=en_US.UTF-8

# grubby --remove-args='rd.lvm.lv=rhel_ibm-p8-storage-02-guest-15/swap' --update-kernel=/boot/vmlinuz-3.10.0-862.14.1.el7.ppc64le

It actually end up removing "rd.lvm.lv=rhel_ibm-p8-storage-02-guest-15/root" instead of swap which caused the system unable to boot later on.

Version-Release number of selected component (if applicable):
grubby-8.28-25.el7

Comment 1 Javier Martinez Canillas 2018-09-17 10:11:02 UTC

(In reply to Qian Cai from comment #0)
> Description of problem:
> # cat /proc/cmdline 
> BOOT_IMAGE=/vmlinuz-3.10.0-862.14.1.el7.ppc64le
> root=/dev/mapper/rhel_ibm--p8--storage--02--guest--15-root ro
> crashkernel=auto rd.lvm.lv=rhel_ibm-p8-storage-02-guest-15/root
> rd.lvm.lv=rhel_ibm-p8-storage-02-guest-15/swap LANG=en_US.UTF-8
> 
> # grubby --remove-args='rd.lvm.lv=rhel_ibm-p8-storage-02-guest-15/swap'
> --update-kernel=/boot/vmlinuz-3.10.0-862.14.1.el7.ppc64le
> 
> It actually end up removing "rd.lvm.lv=rhel_ibm-p8-storage-02-guest-15/root"
> instead of swap which caused the system unable to boot later on.
> 
> Version-Release number of selected component (if applicable):
> grubby-8.28-25.el7

Did this work on RHEL 7.5?

Comment 2 Qian Cai 2018-09-17 12:08:13 UTC

No

Comment 3 Javier Martinez Canillas 2018-09-17 13:24:04 UTC

I see, that this is a duplicate of bug 1476273.

Qian,

Could you please test the following scratch build?

https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=18361366

Comment 4 Qian Cai 2018-09-17 13:31:54 UTC

It works fine.

*** This bug has been marked as a duplicate of bug 1476273 ***