Bug 1476273 - grubby removes wrong parameters when using --remove-args=rd.lvm.lv=vg/lv
grubby removes wrong parameters when using --remove-args=rd.lvm.lv=vg/lv
Status: POST
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: grubby (Show other bugs)
Unspecified Unspecified
medium Severity high
: rc
: ---
Assigned To: Peter Jones
Release Test Team
Depends On:
  Show dependency treegraph
Reported: 2017-07-28 09:27 EDT by Jesús Serrano Sánchez-Toscano
Modified: 2018-05-16 07:31 EDT (History)
7 users (show)

See Also:
Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Last Closed:
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 887123 None None None 2018-03-27 22:32 EDT

  None (edit)
Description Jesús Serrano Sánchez-Toscano 2017-07-28 09:27:08 EDT
Description of problem:
When using grubby to remove a specific LVM parameter (rd.lvm.lv) from the file /etc/grub2.cfg, it removes an incorrect one. Even if a non-existing combination of VG/LV is given to the argument "--remove-args=rd.lvm.lv=vg/lv", it removes a parameter of type "rd.lvm.lv" instead of giving a warning and not modifying the /etc/grub2.cfg.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Check the occurrences of the parameter 'rd.lvm.lv' from the /etc/grub2.cfg file:

[root@fvm-rhel-7-3-35 ~]# egrep -o 'rd.lvm.lv=\S+' /etc/grub2.cfg | sort -u

2. Use grubby to remove the parameter 'rd.lvm.lv' which references to the swap LV:

[root@fvm-rhel-7-3-35 ~]# grubby --update-kernel=ALL --remove-args=rd.lvm.lv=r7vg/swap_lv

3. Check the result of what grubby has deleted:

[root@fvm-rhel-7-3-35 ~]# egrep -o 'rd.lvm.lv=\S+' /etc/grub2.cfg | sort -u

Actual results:
It deletes a wrong parameter 'rd.lvm.lv' from the kernel boot line in the file /etc/grub2.cfg

Expected results:
Grubby should delete only the parameter indicated with the option "--remove-args=vg/lv" or give a warning if it doesn't find it in any of the kernel boot lines from the file /etc/grub2.cfg.

Additional info:

Note You need to log in before you can comment on or make changes to this bug.