Bug 1630673

Summary:	geo-rep: geo-rep config set fails to set rsync-options
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	geo-replication	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	high
Version:	5	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-5.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1629561	Environment:
Last Closed:	2018-10-23 15:19:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1629561
Bug Blocks:	1630140

Description Kotresh HR 2018-09-19 04:05:03 UTC

+++ This bug was initially created as a clone of Bug #1629561 +++

Description of problem:
geo-rep config fails to set rsync-options to "--ignore-missing-args"


Version-Release number of selected component (if applicable):
mainline

How reproducible:
Always

Steps to Reproduce:
1. Setup geo-rep between two gluster volumes and start
2. gluster vol set <master> <slavehost>::<slavevol> config rsync-options "--ignore-missing-args"

Actual results:
config set fails

Expected results:
config set should not fail

Additional info:

--- Additional comment from Worker Ant on 2018-09-17 03:35:58 EDT ---

REVIEW: https://review.gluster.org/21191 (geo-rep: Fix issues related config set) posted (#1) for review on master by Kotresh HR

--- Additional comment from Worker Ant on 2018-09-18 00:28:41 EDT ---

COMMIT: https://review.gluster.org/21191 committed in master by "Amar Tumballi" <amarts> with a commit message- geo-rep: Fix issues related config set

1. '--ignore-mising-args' option for rsync is not
   being used even though the rsync version is
   greater than 3.1.0. Fixed the same.

2. '--existing' option for rsync is also not being
   used. Fixed the same.

3. geo-rep config fails to set rsync-options as the
   value contains '--'. Interestingly, python argsparse
   treats the value with '--' (e.g., --ignore-missing-args)
   as option. But when passed with something like
   --value=--ignore-missing-args, it succeeds. Fixed the
   same.

Change-Id: Iaeb838acaff1c2920fee9c7f920c99edce13a0a1
Signed-off-by: Kotresh HR <khiremat>
fixes: bz#1629561

Comment 1 Worker Ant 2018-09-19 04:11:54 UTC

REVIEW: https://review.gluster.org/21212 (geo-rep: Fix issues related config set) posted (#1) for review on release-5 by Kotresh HR

Comment 2 Worker Ant 2018-09-24 13:56:32 UTC

COMMIT: https://review.gluster.org/21212 committed in release-5 by "Kotresh HR" <khiremat> with a commit message- geo-rep: Fix issues related config set

1. '--ignore-mising-args' option for rsync is not
   being used even though the rsync version is
   greater than 3.1.0. Fixed the same.

2. '--existing' option for rsync is also not being
   used. Fixed the same.

3. geo-rep config fails to set rsync-options as the
   value contains '--'. Interestingly, python argsparse
   treats the value with '--' (e.g., --ignore-missing-args)
   as option. But when passed with something like
   --value=--ignore-missing-args, it succeeds. Fixed the
   same.

Backport of:
 > Patch: https://review.gluster.org/21191
 > Change-Id: Iaeb838acaff1c2920fee9c7f920c99edce13a0a1
 > Signed-off-by: Kotresh HR <khiremat>
 > BUG: 1629561
(cherry picked from commit b977b44dd0adfcd7a3b432844260de4b8d1c4adf)

Change-Id: Iaeb838acaff1c2920fee9c7f920c99edce13a0a1
Signed-off-by: Kotresh HR <khiremat>
fixes: bz#1630673

Comment 3 Shyamsundar 2018-10-23 15:19:19 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-5.0, please open a new bug report.

glusterfs-5.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2018-October/000115.html
[2] https://www.gluster.org/pipermail/gluster-users/