Bug 1631587
| Summary: | [RFE] Improve vdsm client to add correlation_id | ||
|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Germano Veit Michel <gveitmic> |
| Component: | Bindings-API | Assignee: | Marcin Sobczyk <msobczyk> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Petr Matyáš <pmatyas> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.30.0 | CC: | bugs, emarcus, mperina, msobczyk, mtessun, pkliczew |
| Target Milestone: | ovirt-4.3.3 | Keywords: | FutureFeature |
| Target Release: | --- | Flags: | mperina:
ovirt-4.3?
mperina: exception? mtessun: planning_ack+ mperina: devel_ack+ lleistne: testing_ack+ |
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | vdsm-4.30.12 | Doc Type: | Enhancement |
| Doc Text: |
In this release, the Correlation-Id can be passed to the vdsm-client by using the '--flow-id' argument with the vdsm-client tool.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-04-16 13:58:35 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Marking as exception, because we really need this RFE to help CEE, more details in https://bugzilla.redhat.com/show_bug.cgi?id=1609953#c14 and followup comments What are the verification steps? The steps to verify are: 1. Log into any any host VM with ssh 2. Call any method using 'vdsm-client' with '--flow-id' argument provided, i.e.: vdsm-client --flow-id=myflowid Host getStats 3. Grep for 'myflowid' in '/var/log/vdsm/vdsm.log' to see if your 'getStats' call is annotated with provided flow id. Verified on vdsm-4.30.12-1.el7ev.x86_64 This bugzilla is included in oVirt 4.3.3 release, published on April 16th 2019. Since the problem described in this bug report should be resolved in oVirt 4.3.3 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. @Eli, the new Doc Text looks great, thanks! |
Description of problem: When using the vdsm client (python), it is not currently possible to send an extra header to add the correlation/flow id. For example: from vdsm import client cli = client.connect('localhost', 54321, use_tls=True) cli.some_api_command() Similar to this[1], but for the python client. [1] https://github.com/oVirt/vdsm-jsonrpc-java/commit/2318ffe9c637a2a171ea0cb7d4111d41af5c1c81