Bug 1631587 - [RFE] Improve vdsm client to add correlation_id
Summary: [RFE] Improve vdsm client to add correlation_id
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Bindings-API
Version: 4.30.0
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ovirt-4.3.3
: ---
Assignee: Marcin Sobczyk
QA Contact: Petr Matyáš
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-21 01:44 UTC by Germano Veit Michel
Modified: 2019-05-13 10:57 UTC (History)
6 users (show)

Fixed In Version: vdsm-4.30.12
Clone Of:
Environment:
Last Closed: 2019-04-16 13:58:35 UTC
oVirt Team: Infra
Embargoed:
mperina: ovirt-4.3?
mperina: exception?
mtessun: planning_ack+
mperina: devel_ack+
lleistne: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 98372 0 'None' MERGED vdsm: client: Add support for flow id 2020-08-19 00:08:51 UTC
oVirt gerrit 98748 0 'None' MERGED vdsm: client: Add support for flow id 2020-08-19 00:08:51 UTC

Description Germano Veit Michel 2018-09-21 01:44:11 UTC 
Description of problem:

When using the vdsm client (python), it is not currently possible to send an extra header to add the correlation/flow id.

For example:

from vdsm import client
cli = client.connect('localhost', 54321, use_tls=True)
cli.some_api_command()

Similar to this[1], but for the python client.

[1] https://github.com/oVirt/vdsm-jsonrpc-java/commit/2318ffe9c637a2a171ea0cb7d4111d41af5c1c81
Comment 1 Martin Perina 2019-03-08 09:35:14 UTC 
Marking as exception, because we really need this RFE to help CEE, more details in https://bugzilla.redhat.com/show_bug.cgi?id=1609953#c14 and followup comments
Comment 2 Lucie Leistnerova 2019-03-26 16:58:22 UTC 
What are the verification steps?
Comment 3 Marcin Sobczyk 2019-03-27 14:46:10 UTC 
The steps to verify are:

1. Log into any any host VM with ssh
2. Call any method using 'vdsm-client' with '--flow-id' argument provided, i.e.:

 vdsm-client --flow-id=myflowid Host getStats

3. Grep for 'myflowid' in '/var/log/vdsm/vdsm.log' to see if your 'getStats' call is annotated with provided flow id.
Comment 4 Petr Matyáš 2019-03-29 13:48:57 UTC 
Verified on vdsm-4.30.12-1.el7ev.x86_64
Comment 6 Sandro Bonazzola 2019-04-16 13:58:35 UTC 
This bugzilla is included in oVirt 4.3.3 release, published on April 16th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.3 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Comment 7 Marcin Sobczyk 2019-05-13 09:48:08 UTC 
@Eli, the new Doc Text looks great, thanks!
Note You need to log in before you can comment on or make changes to this bug.