Bug 1631892

Summary:	To be able to add and create reports, the edit report role is needed.
Product:	Red Hat CloudForms Management Engine	Reporter:	David Luong <dluong>
Component:	UI - OPS	Assignee:	Harpreet Kataria <hkataria>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Antonin Pagac <apagac>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.9.4	CC:	abellott, dmetzger, hkataria, lavenel, mpovolny, obarenbo, simaishi, smallamp
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.10.0.18	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1634032 (view as bug list)		Environment:
Last Closed:	2019-02-12 16:53:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1634032

Description David Luong 2018-09-21 20:16:23 UTC

Description of problem:
Granting add and copy reports does not allow for add or copy.  Adding edit report allows both add and copy to work.  

Version-Release number of selected component (if applicable):
5.9.4

How reproducible:
Always

Steps to Reproduce:
- Create a reporting role and grant roles as shown in attached pic.
- Create a reporting group using the reporting role.
- Configure a report as admin.
- Add it to the reports menu for the reports role/group (see image).
- Switch to reporting role.
- Attempt to create a new role and copy the existing report (see video).
- Add edit role, and note it works after.

Actual results:
Cannot copy report with copy role on

Expected results:
Can copy report

Additional info:

Comment 3 Harpreet Kataria 2018-09-24 20:19:57 UTC

https://github.com/ManageIQ/manageiq-ui-classic/pull/4699

Comment 5 Harpreet Kataria 2018-09-26 18:57:01 UTC

Brad,

No RBAC changes needed, once they have the fix, they should be able to add Reports with the RBAC feature setup they have where user does not have access to edit a report but is allowed to add one.

~Harpreet

Comment 6 CFME Bot 2018-09-27 18:07:18 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/b44e5a27fdff8ba84f976ca58495a4facc573953
commit b44e5a27fdff8ba84f976ca58495a4facc573953
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Sep 24 09:57:25 2018 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Sep 24 09:57:25 2018 -0400

    Fixed code to check for correct RBAC feature when adding/editing report

    Previously it was always checking for "miq_report_edit" feature when adding a report or changing between tabs in report editor. Fixed to check for correct feature id.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1631892

 app/controllers/report_controller/reports/editor.rb | 47 +-
 spec/controllers/miq_report_controller/reports/editor_spec.rb | 44 +-
 2 files changed, 65 insertions(+), 26 deletions(-)

Comment 9 CFME Bot 2018-10-01 19:03:29 UTC

New commit detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/36be961ffbdffe3ea2931918de0c8573c2debd13
commit 36be961ffbdffe3ea2931918de0c8573c2debd13
Author:     Dan Clarizio <dclarizi>
AuthorDate: Thu Sep 27 14:04:22 2018 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Thu Sep 27 14:04:22 2018 -0400

    Merge pull request #4699 from h-kataria/report_editor_rbac_check_fixed

    Fixed code to check for correct RBAC feature when adding/editing report

    (cherry picked from commit e1897a0e06d84ab4ca370dc4c4254aa6fb42f159)

    https://bugzilla.redhat.com/show_bug.cgi?id=1631892

 app/controllers/report_controller/reports/editor.rb | 47 +-
 spec/controllers/miq_report_controller/reports/editor_spec.rb | 44 +-
 2 files changed, 65 insertions(+), 26 deletions(-)

Comment 10 Antonin Pagac 2018-10-11 12:41:57 UTC

Verified with 5.10.0.19.

Can copy/add report without the Edit report role enabled.