Description of problem: Granting add and copy reports does not allow for add or copy. Adding edit report allows both add and copy to work. Version-Release number of selected component (if applicable): 5.9.4 How reproducible: Always Steps to Reproduce: - Create a reporting role and grant roles as shown in attached pic. - Create a reporting group using the reporting role. - Configure a report as admin. - Add it to the reports menu for the reports role/group (see image). - Switch to reporting role. - Attempt to create a new role and copy the existing report (see video). - Add edit role, and note it works after. Actual results: Cannot copy report with copy role on Expected results: Can copy report Additional info:
https://github.com/ManageIQ/manageiq-ui-classic/pull/4699
Brad, No RBAC changes needed, once they have the fix, they should be able to add Reports with the RBAC feature setup they have where user does not have access to edit a report but is allowed to add one. ~Harpreet
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/b44e5a27fdff8ba84f976ca58495a4facc573953 commit b44e5a27fdff8ba84f976ca58495a4facc573953 Author: Harpreet Kataria <hkataria> AuthorDate: Mon Sep 24 09:57:25 2018 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Mon Sep 24 09:57:25 2018 -0400 Fixed code to check for correct RBAC feature when adding/editing report Previously it was always checking for "miq_report_edit" feature when adding a report or changing between tabs in report editor. Fixed to check for correct feature id. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1631892 app/controllers/report_controller/reports/editor.rb | 47 +- spec/controllers/miq_report_controller/reports/editor_spec.rb | 44 +- 2 files changed, 65 insertions(+), 26 deletions(-)
New commit detected on ManageIQ/manageiq-ui-classic/hammer: https://github.com/ManageIQ/manageiq-ui-classic/commit/36be961ffbdffe3ea2931918de0c8573c2debd13 commit 36be961ffbdffe3ea2931918de0c8573c2debd13 Author: Dan Clarizio <dclarizi> AuthorDate: Thu Sep 27 14:04:22 2018 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Thu Sep 27 14:04:22 2018 -0400 Merge pull request #4699 from h-kataria/report_editor_rbac_check_fixed Fixed code to check for correct RBAC feature when adding/editing report (cherry picked from commit e1897a0e06d84ab4ca370dc4c4254aa6fb42f159) https://bugzilla.redhat.com/show_bug.cgi?id=1631892 app/controllers/report_controller/reports/editor.rb | 47 +- spec/controllers/miq_report_controller/reports/editor_spec.rb | 44 +- 2 files changed, 65 insertions(+), 26 deletions(-)
Verified with 5.10.0.19. Can copy/add report without the Edit report role enabled.