Bug 1632023
Summary: | coccinelle-1.0.7 is available | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Upstream Release Monitoring <upstream-release-monitoring> | ||||||
Component: | coccinelle | Assignee: | Richard W.M. Jones <rjones> | ||||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | rawhide | CC: | jfrie, jglisse, rjones | ||||||
Target Milestone: | --- | Keywords: | FutureFeature, Triaged | ||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Enhancement | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2018-11-05 10:32:16 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Upstream Release Monitoring
2018-09-23 12:13:22 UTC
Ping. The new upstream version fixes the longstanding BZ-1544204 "spatch can't run python scripts". I've installed 1.0.7 locally using similar %build commands, and can verify it resovles the problem as do others in the issue mentioned. Please upgrade the package to upstream. What is your FAS account name? I can add you as comaintainer and you can do the update yourself. Created attachment 1501281 [details]
Test file for coccinelle python support
// Here's what broken python support (using /dev/zero as dummy "c input file")
$ spatch --sp-file py.cocci /dev/zero
init_defs_builtins: /usr/lib64/coccinelle/standard.h
Python error: No module named coccilib.elems
Oh sorry, I'm a fedora user but not a packager. If you're not sure about testing the fix, I've attached a test file for checking support. The output shown is what the current 1.0.6 broken support looks like. A working installation should print "hello world!" instead. If you're just busy, https://bugzilla.redhat.com/show_bug.cgi?id=1544204 has an attached updated spec file for 1.0.7. Also, Jerome Glisse (@redhat.com) also seemed in the loop, perhaps he'd be willing to help? Added as CC. https://bugzilla.redhat.com/show_bug.cgi?id=1544204#c3 I ran the test in comment 3 but it says: + /home/rjones/rpmbuild/BUILDROOT/coccinelle-1.0.7-1.fc30.x86_64/usr/bin/spatch --sp-file /home/rjones/d/fedora/coccinelle/master/pytest.cocci /dev/zero init_defs_builtins: /home/rjones/rpmbuild/BUILDROOT/coccinelle-1.0.7-1.fc30.x86_64/usr/lib64/coccinelle/standard.h Python error: No module named 'coccilib' Of course maybe there is some problem when running the test from the build directory. https://koji.fedoraproject.org/koji/taskinfo?taskID=30683208 Fixed in Rawhide. Created attachment 1502113 [details]
coccinelle 1.0.7 spec file for fc29
// Test for successful install
$ echo > foo.c; spatch --sp-file py.cocci foo.c
init_defs_builtins: /usr/lib64/coccinelle/standard.h
HANDLING: foo.c
Hello World!
Thank you for dealing with this so quickly, I appreciate it. I used rpmbuild on fc29 with the new spec file. Yes, python works now but the installation is wired wrong: $ echo > foo.c; spatch --sp-file py.cocci foo.c warning: Can't find macro file: /usr/bin/../lib/coccinelle/standard.h warning: Can't find default iso file: /usr/bin/../lib/coccinelle/standard.iso HANDLING: foo.c Hello World! IIUC, upstream planned for spatch binary to live in cocc home dir "/usr/lib64/coccinelle/", not /bin. Instead script/spatch.sh is called, sets COCCINELLE_HOME and uses it to call the binary. with that in place: # echo > foo.c; spatch --sp-file py.cocci foo.c init_defs_builtins: /usr/lib64/coccinelle/standard.h HANDLING: foo.c Hello World! i.e. python works and no warnings issues. I also had some autotools version trouble, requiring a reun of aclocal/automake in bundles/stdcompat/stdcompat-6 to fix (it wants 1.15, fc29 has 1.16 autotools). attached my hacked spec files, which installs script/spatch.sh as /bin/spatch. Also, please remember that needs to get into fc29 updates as well, not just rawhide (or am I misunderstanding the koji workflow?). P.S. Friendly reminder: you should leave a blank line between the subject of a git commit message, and the message body, otherwise "git log" output looks terrible. See https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html or any number of "git commit messages" blog posts. Thanks again. |