Bug 1632023 - coccinelle-1.0.7 is available
Summary: coccinelle-1.0.7 is available
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: coccinelle
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-09-23 12:13 UTC by Upstream Release Monitoring
Modified: 2018-11-08 08:31 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-11-05 10:32:16 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Test file for coccinelle python support (40 bytes, text/plain)
2018-11-04 14:16 UTC, John Friend
no flags Details
coccinelle 1.0.7 spec file for fc29 (18.92 KB, text/x-matlab)
2018-11-05 19:17 UTC, John Friend
no flags Details

Description Upstream Release Monitoring 2018-09-23 12:13:22 UTC
Latest upstream release: 1.0.7
Current version/release in rawhide: 1.0.6-20.fc29
URL: http://coccinelle.lip6.fr/download.php

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/314/

Comment 1 John Friend 2018-11-04 07:15:05 UTC
Ping. The new upstream version fixes the longstanding BZ-1544204 "spatch can't run python scripts". I've installed 1.0.7 locally using similar %build commands,
and can verify it resovles the problem as do others in the issue mentioned.

Please upgrade the package to upstream.

Comment 2 Richard W.M. Jones 2018-11-04 11:01:53 UTC
What is your FAS account name?  I can add you as comaintainer and
you can do the update yourself.

Comment 3 John Friend 2018-11-04 14:16:52 UTC
Created attachment 1501281 [details]
Test file for coccinelle python support

// Here's what broken python support (using /dev/zero as dummy "c input file")
$ spatch --sp-file py.cocci /dev/zero
init_defs_builtins: /usr/lib64/coccinelle/standard.h
Python error: No module named coccilib.elems

Comment 4 John Friend 2018-11-04 14:25:33 UTC
Oh sorry, I'm a fedora user but not a packager.

If you're not sure about testing the fix, I've attached a test file for checking support. The output shown is what the current 1.0.6 broken support looks like.
A working installation should print "hello world!" instead.

If you're just busy, 

https://bugzilla.redhat.com/show_bug.cgi?id=1544204

has an attached updated spec file for 1.0.7. Also, Jerome Glisse (@redhat.com)
also seemed in the loop, perhaps he'd be willing to help? Added as CC.

https://bugzilla.redhat.com/show_bug.cgi?id=1544204#c3

Comment 5 Richard W.M. Jones 2018-11-05 10:12:26 UTC
I ran the test in comment 3 but it says:

+ /home/rjones/rpmbuild/BUILDROOT/coccinelle-1.0.7-1.fc30.x86_64/usr/bin/spatch --sp-file /home/rjones/d/fedora/coccinelle/master/pytest.cocci /dev/zero
init_defs_builtins: /home/rjones/rpmbuild/BUILDROOT/coccinelle-1.0.7-1.fc30.x86_64/usr/lib64/coccinelle/standard.h
Python error: No module named 'coccilib'

Of course maybe there is some problem when running the test from
the build directory.

Comment 6 Richard W.M. Jones 2018-11-05 10:32:16 UTC
https://koji.fedoraproject.org/koji/taskinfo?taskID=30683208

Fixed in Rawhide.

Comment 7 John Friend 2018-11-05 19:17:25 UTC
Created attachment 1502113 [details]
coccinelle 1.0.7 spec file for fc29

// Test for successful install

$ echo > foo.c; spatch --sp-file py.cocci foo.c
init_defs_builtins: /usr/lib64/coccinelle/standard.h
HANDLING: foo.c
Hello World!

Comment 8 John Friend 2018-11-05 19:28:59 UTC
Thank you for dealing with this so quickly, I appreciate it.

I used rpmbuild on fc29 with the new spec file. Yes, python works now but the installation is wired wrong:

$ echo > foo.c; spatch --sp-file py.cocci foo.c 
warning: Can't find macro file: /usr/bin/../lib/coccinelle/standard.h
warning: Can't find default iso file: /usr/bin/../lib/coccinelle/standard.iso
HANDLING: foo.c
Hello World!

IIUC, upstream planned for spatch binary to live in cocc home dir "/usr/lib64/coccinelle/", not /bin. Instead script/spatch.sh is called, sets COCCINELLE_HOME and uses it to call the binary. with that in place:

# echo > foo.c; spatch --sp-file py.cocci foo.c
init_defs_builtins: /usr/lib64/coccinelle/standard.h
HANDLING: foo.c
Hello World!

i.e. python works and no warnings issues.

I also had some autotools version trouble, requiring a reun of aclocal/automake in bundles/stdcompat/stdcompat-6 to fix (it wants 1.15, fc29 has 1.16 autotools).

attached my hacked spec files, which installs script/spatch.sh as /bin/spatch.

Also, please remember that needs to get into fc29 updates as well, not just rawhide (or am I misunderstanding the koji workflow?). 


P.S.

Friendly reminder: you should leave a blank line between the subject of a git commit message, and the message body, otherwise "git log" output looks terrible. 

See
 https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
or any number of "git commit messages" blog posts.

Thanks again.

Comment 9 John Friend 2018-11-08 08:31:08 UTC
Moved "not-found warnings" to BZ1647715


Note You need to log in before you can comment on or make changes to this bug.