Bug 1633125

Summary:	tendrl-upgrade script should print additional information and request confirmation before any action
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Daniel Horák <dahorak>
Component:	web-admin-tendrl-monitoring-integration	Assignee:	gowtham <gshanmug>
Status:	CLOSED WONTFIX	QA Contact:	sds-qe-bugs
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.4	CC:	asachan, mbukatov, rhs-bugs, sankarshan, shtripat
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-08 18:49:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Daniel Horák 2018-09-26 08:59:59 UTC

Description of problem:

It might be good to improve the tendrl-upgrade script as described in
Bug 1631260 comment 18:
> 2) It might be worth, to firstly print some information message - what is
> the purpose of the script, what is the prerequisite (e.g. stopped
> tendrl-monitoring service) and what it will do and then ask the user for
> Yes/No agreement if he want to continue.
> Of course, there might be some command line parameter, which will
> automatically
> except yes for the question (something like -y, --assumeyes in yum).


Version-Release number of selected component (if applicable):
  tendrl-monitoring-integration-1.6.3-13.el7rhgs.noarch

How reproducible:
  100%

Steps to Reproduce:
  Follow upgrade process from RHGS WA 3.4.0 to BU1 and
  focus on the part related to execution of tendrl-upgrade script.

Actual results:
  Executing tendrl-upgrade script will immediately delete all grafana
  dashboards, without requiring any confirmation or explanation what
  it will do.

Expected results:
  It will be worth to firstly print some information about the purpose of the
  script and whats are the prerequisites and then require confirmation that
  the process should continue.

Additional info:
  See also Bug 1631260.

Comment 1 Shubhendu Tripathi 2018-11-19 13:13:15 UTC

@Anmol, is this script still there? Wasn't this incorporated as part of tendrl-monitoring-integration itself?

Comment 2 Anmol Sachan 2018-11-19 14:12:31 UTC

@shubhendu , The script is still present and is present at https://github.com/Tendrl/monitoring-integration/blob/615ce4a583e20b217bd0f0241bd41cdf11602d4f/setup.py#L117.

Comment 3 Martin Bukatovic 2019-01-07 16:32:26 UTC

Now with upcoming RHGSWA 3.4.3 it's even worse: some actions (rename of directories in /var/lib/carbon and migration of graphite data) are performed even if one runs the script with --help flag, because these actions are done before command line arguments processing.