Fedora Account System
Red Hat Associate
Red Hat Customer
Description of problem: It might be good to improve the tendrl-upgrade script as described in Bug 1631260 comment 18: > 2) It might be worth, to firstly print some information message - what is > the purpose of the script, what is the prerequisite (e.g. stopped > tendrl-monitoring service) and what it will do and then ask the user for > Yes/No agreement if he want to continue. > Of course, there might be some command line parameter, which will > automatically > except yes for the question (something like -y, --assumeyes in yum). Version-Release number of selected component (if applicable): tendrl-monitoring-integration-1.6.3-13.el7rhgs.noarch How reproducible: 100% Steps to Reproduce: Follow upgrade process from RHGS WA 3.4.0 to BU1 and focus on the part related to execution of tendrl-upgrade script. Actual results: Executing tendrl-upgrade script will immediately delete all grafana dashboards, without requiring any confirmation or explanation what it will do. Expected results: It will be worth to firstly print some information about the purpose of the script and whats are the prerequisites and then require confirmation that the process should continue. Additional info: See also Bug 1631260.
@Anmol, is this script still there? Wasn't this incorporated as part of tendrl-monitoring-integration itself?
@shubhendu , The script is still present and is present at https://github.com/Tendrl/monitoring-integration/blob/615ce4a583e20b217bd0f0241bd41cdf11602d4f/setup.py#L117.
Now with upcoming RHGSWA 3.4.3 it's even worse: some actions (rename of directories in /var/lib/carbon and migration of graphite data) are performed even if one runs the script with --help flag, because these actions are done before command line arguments processing.