Bug 1637789

Summary:	need smoke job to FAIL if build fails with '-m32' (ie, non-64)
Product:	[Community] GlusterFS	Reporter:	Amar Tumballi <atumball>
Component:	project-infrastructure	Assignee:	Deepshikha khandelwal <dkhandel>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, gluster-infra, mscherer, nigelb
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-12-03 06:29:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Amar Tumballi 2018-10-10 06:28:31 UTC

Description of problem:
With patch https://review.gluster.org/21276 being merged, we should be passing the build without any warning on non-64bit arch too. To preserve the state, we need a build to FAIL if there are any warnings.

Version-Release number of selected component (if applicable):
master


Expected results:
A build with -m32 to run without any errors to pass the smoke.

Additional info:
When the job gets introduced, we can check for a week with 'skipped' vote, on failure, and then can make sure to PASS it for sometime, and then enable the vote, like we did for other jobs!

Comment 1 Niels de Vos 2018-10-10 08:06:26 UTC

The easiest and most portable way is to build in mock for a 32-bit architecture. That prevents the need for having all 32-bit libraries, development tools and dependencies on the systems.

This normally does quite nicely:

   mock -r fedora-rawhide-i386 rebuild <srcrpm>

The https://build.gluster.org/job/strfmt_errors/ job uses such a configuration already.

Comment 2 Nigel Babu 2018-10-15 02:20:06 UTC

What I currently do is run a mock build on 32-bit and grep it for specific warnings. What we want to do is run that with -Wall and we should be good. I'm going to assign this to sprint 5.

Comment 3 M. Scherer 2018-10-15 08:27:26 UTC

So, if we want the build to fail, shouldn't it be -Werror -Wall ? (and then, I think -Wall is not really "all", there is more warnings out there).

using -Werror to detect failure also bring the question of "what when new warnings are added".

Comment 4 Nigel Babu 2018-12-03 06:29:04 UTC

This is now done. There is a non-voting job that is failing. Please fix the warnings and file a new bug for a voting job.