Bug 1637789 - need smoke job to FAIL if build fails with '-m32' (ie, non-64)
Summary: need smoke job to FAIL if build fails with '-m32' (ie, non-64)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: project-infrastructure
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Deepshikha khandelwal
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-10-10 06:28 UTC by Amar Tumballi
Modified: 2018-12-03 06:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-12-03 06:29:04 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Amar Tumballi 2018-10-10 06:28:31 UTC
Description of problem:
With patch https://review.gluster.org/21276 being merged, we should be passing the build without any warning on non-64bit arch too. To preserve the state, we need a build to FAIL if there are any warnings.

Version-Release number of selected component (if applicable):
master


Expected results:
A build with -m32 to run without any errors to pass the smoke.

Additional info:
When the job gets introduced, we can check for a week with 'skipped' vote, on failure, and then can make sure to PASS it for sometime, and then enable the vote, like we did for other jobs!

Comment 1 Niels de Vos 2018-10-10 08:06:26 UTC
The easiest and most portable way is to build in mock for a 32-bit architecture. That prevents the need for having all 32-bit libraries, development tools and dependencies on the systems.

This normally does quite nicely:

   mock -r fedora-rawhide-i386 rebuild <srcrpm>

The https://build.gluster.org/job/strfmt_errors/ job uses such a configuration already.

Comment 2 Nigel Babu 2018-10-15 02:20:06 UTC
What I currently do is run a mock build on 32-bit and grep it for specific warnings. What we want to do is run that with -Wall and we should be good. I'm going to assign this to sprint 5.

Comment 3 M. Scherer 2018-10-15 08:27:26 UTC
So, if we want the build to fail, shouldn't it be -Werror -Wall ? (and then, I think -Wall is not really "all", there is more warnings out there).

using -Werror to detect failure also bring the question of "what when new warnings are added".

Comment 4 Nigel Babu 2018-12-03 06:29:04 UTC
This is now done. There is a non-voting job that is failing. Please fix the warnings and file a new bug for a voting job.


Note You need to log in before you can comment on or make changes to this bug.