Bug 1637846

Summary: RemoveVmCommand doesn't log the user
Product: Red Hat Enterprise Virtualization Manager Reporter: Olimp Bockowski <obockows>
Component: ovirt-engineAssignee: Andrej Krejcir <akrejcir>
Status: CLOSED ERRATA QA Contact: Ryan Barry <rbarry>
Severity: high Docs Contact:
Priority: high    
Version: 4.2.6CC: akrejcir, michal.skrivanek, rbarry, Rhev-m-bugs
Target Milestone: ovirt-4.3.0Keywords: Rebase, ZStream
Target Release: ---Flags: lsvaty: testing_plan_complete-
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-4.3.0_rc Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1655027 (view as bug list) Environment:
Last Closed: 2019-05-08 12:38:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1655027    

Description Olimp Bockowski 2018-10-10 08:11:56 UTC
Description of problem:
There is a problem that user who removes VM is not recorded in the audit log and in events tab. This action is the most critical and should be logged without any doubts.

Version-Release number of selected component (if applicable):
RHV 4.2.*

How reproducible:
every time

Steps to Reproduce:
1. log in as some user
2. delete VM
3. check audit log or event tabs

Actual results:
The responsible user is not recorded.

Expected results:
It is logged who removes a VM

Additional info:
A fix requires a small change. 

removing is handled by RemoveVmCommand with following signature:

/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
public AuditLogType getAuditLogTypeValue()
return getSucceeded() ? AuditLogType.USER_REMOVE_VM_FINISHED

the message is in:
/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
USER_REMOVE_VM_FINISHED=VM ${VmName} was successfully removed.

Comment 2 Michal Skrivanek 2018-11-15 13:35:03 UTC
require acks

Comment 3 RHV bug bot 2018-11-28 14:38:14 UTC
WARN: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]

For more info please contact: rhv-devops: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]

For more info please contact: rhv-devops

Comment 6 errata-xmlrpc 2019-05-08 12:38:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1085

Comment 7 Daniel Gur 2019-08-28 13:11:55 UTC
sync2jira

Comment 8 Daniel Gur 2019-08-28 13:16:07 UTC
sync2jira