Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1655027

Summary: [downstream clone - 4.2.8] RemoveVmCommand doesn't log the user
Product: Red Hat Enterprise Virtualization Manager Reporter: RHV bug bot <rhv-bugzilla-bot>
Component: ovirt-engineAssignee: Andrej Krejcir <akrejcir>
Status: CLOSED ERRATA QA Contact: Pedut <pchocron>
Severity: high Docs Contact:
Priority: high    
Version: 4.2.6CC: akrejcir, michal.skrivanek, ratamir, rbarry, Rhev-m-bugs
Target Milestone: ovirt-4.2.8Keywords: Rebase, ZStream
Target Release: ---Flags: lsvaty: testing_plan_complete-
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-4.2.8.1 Doc Type: Rebase: Bug Fixes and Enhancements
Doc Text:
Story Points: ---
Clone Of: 1637846 Environment:
Last Closed: 2019-01-22 12:44:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1637846    
Bug Blocks:    

Description RHV bug bot 2018-11-30 11:21:11 UTC 
+++ This bug is a downstream clone. The original bug is: +++
+++   bug 1637846 +++
======================================================================

Description of problem:
There is a problem that user who removes VM is not recorded in the audit log and in events tab. This action is the most critical and should be logged without any doubts.

Version-Release number of selected component (if applicable):
RHV 4.2.*

How reproducible:
every time

Steps to Reproduce:
1. log in as some user
2. delete VM
3. check audit log or event tabs

Actual results:
The responsible user is not recorded.

Expected results:
It is logged who removes a VM

Additional info:
A fix requires a small change. 

removing is handled by RemoveVmCommand with following signature:

/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
public AuditLogType getAuditLogTypeValue()
return getSucceeded() ? AuditLogType.USER_REMOVE_VM_FINISHED

the message is in:
/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
USER_REMOVE_VM_FINISHED=VM ${VmName} was successfully removed.

(Originally by Olimp Bockowski)
Comment 2 RHV bug bot 2018-11-30 11:21:18 UTC 
require acks

(Originally by michal.skrivanek)
Comment 3 RHV bug bot 2018-11-30 11:21:21 UTC 
WARN: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]

For more info please contact: rhv-devops: Bug status (VERIFIED) wasn't changed but the folowing should be fixed:

[Found non-acked flags: '{'rhevm-4.2.z': '?'}', ]

For more info please contact: rhv-devops

(Originally by rhv-bugzilla-bot)
Comment 5 Pedut 2018-12-31 07:43:23 UTC 
Verified on Verified on 4.2.8.1-0.1.el7.
Comment 7 errata-xmlrpc 2019-01-22 12:44:51 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0121
Comment 8 Daniel Gur 2019-08-28 13:15:33 UTC 
sync2jira
Comment 9 Daniel Gur 2019-08-28 13:21:22 UTC 
sync2jira