Bug 164251
| Summary: | segfault on startup on x86_64 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Noa Resare <noa> | ||||||
| Component: | john | Assignee: | Till Maas <opensource> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 4 | CC: | extras-qa, hdegoede, scop | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | 1.7.0.2-3 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2007-03-01 19:59:24 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 162161 | ||||||||
| Attachments: |
|
||||||||
Created attachment 117149 [details]
autodetect platforms where sizeof(void*) == sizeof(long)
Thanks for this report and the patch!!! I will test it later this week and get the new RPMS upstream. Thanks again, Gavin. Ping? This still happens in FC5, john-1.6-4. Haven't I done this yet? Sorry. Will get on it. ping again? Should get this nailed this week. Thanks for your patience. Gavin. Sending for rebuild now. Build failures, looks like it was not even tested if the %prep stage succeeds (let alone the patched functionality) before submitting the build job :/ http://buildsys.fedoraproject.org/build-status/job.psp?uid=22950 http://buildsys.fedoraproject.org/build-status/job.psp?uid=22951 Sorry about that. Will test again this week. Gavin. john 1.7.0.2-2 has been built for development as job 25388 Please check whether or not john works now on x86_64. I will assume the bug is fixed when you do not respond soon. Well, the package is not available in the devel x86_64 repo. The buildsystem told me the build succeeded, what can I do now? http://buildsys.fedoraproject.org/build-status/job.psp?uid=25388 Created attachment 148873 [details]
Fix odd chars and syntax issues
Dunno, but the binary package is missing from the ppc repository too, ditto in
the FC-6 repo. Before doing anything else, I'd suggest taking a look at these
findings:
There seems to be an odd character of some kind on lines 64 and 83, the "%"
preceding {target_mmx} is not a regular percent sign - I suppose that will
cause some problems.
There is also syntactic problems in the specfile on line 47 (and I suppose on
line 64 and 85 too, they're essentially the same as line 47 after the percent
sign problem has been corrected) when eval'd on x86_64:
$ rpm -q --specfile john.spec
error: syntax error in expression
error: john.spec:47: parseExpressionBoolean returns -1
The attached patch should fix all these issues. And looks like a local x86_64
FC6 build no longer crashes.
I applied your patch, the build succeeded, I hope it will be published, too: http://buildsys.fedoraproject.org/logs/fedora-development-extras/28366-john-1.7.0.2-3.fc7/ Looks good so far, at least all binary packages are in the needsign queue as expected. The FC6 branch needs the fix too, BTW. (In reply to comment #16) > Looks good so far, at least all binary packages are in the needsign queue as > expected. The FC6 branch needs the fix too, BTW. FC6 has been rebuilt, too. |
Description of problem: Due to an incorrect assumpution about the size of pointers on the x86_64 platform john segfaults on startup on that platform. Version-Release number of selected component (if applicable): john-1.6-4 How reproducible: always Steps to Reproduce: 1. unshadow /etc/passwd /etc/shadow > to_crack 2. john to_crack Actual results: Program received signal SIGSEGV, Segmentation fault. 0x00000000004187d5 in ldr_init_database (db=0x537660, options=0x55a810) at loader.c:78 78 issep_map[(ARCH_INDEX)*pos] = 1; Expected results: Some password cracking Additional info: The attached patch has been tested on x86_64 and vanilla x86, and I have verified that it actually cracks simple passwords on both platforms. I haven't looked into submitting this upstream yet.