Bug 1643497

Summary:	Package-review: collectd-rabbitmq-monitoring - Collectd plugin for Rabbitmq
Product:	[Community] RDO	Reporter:	Matthias Runge <mrunge>
Component:	Package Review	Assignee:	Ryan McCabe <rmccabe>
Status:	CLOSED CURRENTRELEASE	QA Contact:	hguemar
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	rmccabe
Target Milestone:	---	Flags:	rmccabe: rdo-review+
Target Release:	trunk
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-06 06:41:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1657147
Bug Blocks:	1290256, 1669093, 1726191

Description Matthias Runge 2018-10-26 12:03:07 UTC

Description:
This plugin provides metrics from a running Rabbitmq cluster via the rabbitmq
management plugin API

SRPM: http://www.matthias-runge.de/fedora/collectd-rabbitmq-monitoring-0.0.5-1.fc28.src.rpm
SPEC: http://www.matthias-runge.de/fedora/collectd-rabbitmq-monitoring.spec

rpmlint SPECS/collectd-rabbitmq-monitoring.spec SRPMS/collectd-rabbitmq-monitoring-0.0.5-1.fc28.src.rpm 
1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Matthias Runge 2018-10-30 11:06:44 UTC

Hmm, this requires pyrabbit, which is not packaged yet. Pyrabbit seems to be dead upstream, and partly replaced by pyrabbit2.

Comment 2 Ryan McCabe 2018-11-01 20:38:53 UTC

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Due to pyrabbit not being present in Fedora.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -collectd-rabbitmq-monitoring , python3-collectd-rabbitmq-monitoring
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.4.13 starting (python version = 3.6.6)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.13
INFO: Mock Version: 1.4.13
Finish: chroot init
INFO: installing package(s): /home/ryan/1643497-collectd-rabbitmq-monitoring/results/python3-collectd-rabbitmq-monitoring-0.0.5-1.fc28.noarch.rpm /home/ryan/1643497-collectd-rabbitmq-monitoring/results/python2-collectd-rabbitmq-monitoring-0.0.5-1.fc28.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-28-x86_64/root/ --releasever 28 --disableplugin=local --setopt=deltarpm=False install /home/ryan/1643497-collectd-rabbitmq-monitoring/results/python3-collectd-rabbitmq-monitoring-0.0.5-1.fc28.noarch.rpm /home/ryan/1643497-collectd-rabbitmq-monitoring/results/python2-collectd-rabbitmq-monitoring-0.0.5-1.fc28.noarch.rpm



Rpmlint
-------
Checking: python2-collectd-rabbitmq-monitoring-0.0.5-1.fc28.noarch.rpm
          python3-collectd-rabbitmq-monitoring-0.0.5-1.fc28.noarch.rpm
          collectd-rabbitmq-monitoring-0.0.5-1.fc28.src.rpm
python2-collectd-rabbitmq-monitoring.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/collectd_rabbitmq_monitoring/__init__.py /usr/bin/env python
python2-collectd-rabbitmq-monitoring.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/collectd_rabbitmq_monitoring/__init__.py 644 /usr/bin/env python
python3-collectd-rabbitmq-monitoring.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/collectd_rabbitmq_monitoring/__init__.py /usr/bin/env python
python3-collectd-rabbitmq-monitoring.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/collectd_rabbitmq_monitoring/__init__.py 644 /usr/bin/env python
3 packages and 0 specfiles checked; 4 errors, 0 warnings.




Requires
--------
python2-collectd-rabbitmq-monitoring (rpmlib, GLIBC filtered):
    python(abi)
    python2dist(pyrabbit)

python3-collectd-rabbitmq-monitoring (rpmlib, GLIBC filtered):
    python(abi)
    python3dist(pyrabbit)



Provides
--------
python2-collectd-rabbitmq-monitoring:
    python2-collectd-rabbitmq-monitoring
    python2.7dist(collectd-rabbitmq-monitoring)
    python2dist(collectd-rabbitmq-monitoring)

python3-collectd-rabbitmq-monitoring:
    python3-collectd-rabbitmq-monitoring
    python3.6dist(collectd-rabbitmq-monitoring)
    python3dist(collectd-rabbitmq-monitoring)



Source checksums
----------------
https://files.pythonhosted.org/packages/source/c/collectd-rabbitmq-monitoring/collectd-rabbitmq-monitoring-0.0.5.tar.gz :
  CHECKSUM(SHA256) this package     : 9620bd1eb94c2ad54006cf350462b85b2c8dd68fedfa827b4154126e2b93192c
  CHECKSUM(SHA256) upstream package : 9620bd1eb94c2ad54006cf350462b85b2c8dd68fedfa827b4154126e2b93192c


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1643497
Buildroot used: fedora-28-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 3 Ryan McCabe 2018-12-12 20:41:51 UTC

The rawhide mock build fails with:

RPM build errors:
    File not found: /builddir/build/BUILDROOT/collectd-rabbitmq-monitoring-0.0.6-1.fc30.noarch/usr/lib/python3.7/site-packages/collectd_rabbitmq_monitoring
    File not found: /builddir/build/BUILDROOT/collectd-rabbitmq-monitoring-0.0.6-1.fc30.noarch/usr/lib/python3.7/site-packages/collectd_rabbitmq_monitoring-*.egg-info

On f29 and older, I believe

BuildRequires: git

is needed, as the builds are failing at:

+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ /usr/bin/git init -q
/var/tmp/rpm-tmp.ZSIBVp: line 42: /usr/bin/git: No such file or directory

Comment 4 Matthias Runge 2018-12-13 12:04:07 UTC

Thank you

could you please give this a try?

SRPM: http://www.matthias-runge.de/fedora/collectd-rabbitmq-monitoring-0.0.6-2.fc29.src.rpm
SPEC: http://www.matthias-runge.de/fedora/collectd-rabbitmq-monitoring.spec

Unfortunately, this fails the same way as you described in #c3 https://kojipkgs.fedoraproject.org//work/tasks/9417/31439417/build.log
but works fine in f29, https://koji.fedoraproject.org/koji/taskinfo?taskID=31439552

Comment 5 Ryan McCabe 2018-12-19 21:06:45 UTC

Notes: Installation error is caused by the lack of pyrabbit2 from mock. The rpmlint warnings are spurious. Looks fine otherwise.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Due to pyrabbit not being present in Fedora.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -collectd-rabbitmq-monitoring , python3-collectd-rabbitmq-monitoring
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 1.4.13 starting (python version = 3.6.7)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.13
INFO: Mock Version: 1.4.13
Finish: chroot init
INFO: installing package(s): /home/ryan/1643497-collectd-rabbitmq-monitoring/results/python2-collectd-rabbitmq-monitoring-0.0.6-2.fc29.noarch.rpm /home/ryan/1643497-collectd-rabbitmq-monitoring/results/python3-collectd-rabbitmq-monitoring-0.0.6-2.fc29.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-29-x86_64/root/ --releasever 29 --disableplugin=local --setopt=deltarpm=False install /home/ryan/1643497-collectd-rabbitmq-monitoring/results/python2-collectd-rabbitmq-monitoring-0.0.6-2.fc29.noarch.rpm /home/ryan/1643497-collectd-rabbitmq-monitoring/results/python3-collectd-rabbitmq-monitoring-0.0.6-2.fc29.noarch.rpm



Rpmlint
-------
Checking: python2-collectd-rabbitmq-monitoring-0.0.6-2.fc29.noarch.rpm
          python3-collectd-rabbitmq-monitoring-0.0.6-2.fc29.noarch.rpm
          collectd-rabbitmq-monitoring-0.0.6-2.fc29.src.rpm
python2-collectd-rabbitmq-monitoring.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/collectd_rabbitmq_monitoring/__init__.py /usr/bin/env python
python2-collectd-rabbitmq-monitoring.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/collectd_rabbitmq_monitoring/__init__.py 644 /usr/bin/env python
python3-collectd-rabbitmq-monitoring.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/collectd_rabbitmq_monitoring/__init__.py /usr/bin/env python
python3-collectd-rabbitmq-monitoring.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/collectd_rabbitmq_monitoring/__init__.py 644 /usr/bin/env python
3 packages and 0 specfiles checked; 4 errors, 0 warnings.




Requires
--------
python2-collectd-rabbitmq-monitoring (rpmlib, GLIBC filtered):
    python(abi)
    python2dist(pyrabbit2)

python3-collectd-rabbitmq-monitoring (rpmlib, GLIBC filtered):
    python(abi)
    python3dist(pyrabbit2)



Provides
--------
python2-collectd-rabbitmq-monitoring:
    python2-collectd-rabbitmq-monitoring
    python2.7dist(collectd-rabbitmq-monitoring)
    python2dist(collectd-rabbitmq-monitoring)

python3-collectd-rabbitmq-monitoring:
    python3-collectd-rabbitmq-monitoring
    python3.7dist(collectd-rabbitmq-monitoring)
    python3dist(collectd-rabbitmq-monitoring)



Source checksums
----------------
https://github.com/centos-opstools/collectd-rabbitmq-monitoring/archive/0.0.6.tar.gz#/collectd-rabbitmq-monitoring-0.0.6.tar.gz :
  CHECKSUM(SHA256) this package     : 45145f6bfcce5867e1aabda90e0d8dd79c532f053f0cfc0dab03ae9084aaca82
  CHECKSUM(SHA256) upstream package : 45145f6bfcce5867e1aabda90e0d8dd79c532f053f0cfc0dab03ae9084aaca82


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1643497
Buildroot used: fedora-29-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 6 Matthias Runge 2019-06-06 06:41:49 UTC

This was added and built in centos-opstools