Bug 1643921

Summary: Incorrect behavior of IOThreads text box in edit VM dialog
Product: [oVirt] ovirt-engine Reporter: meital avital <mavital>
Component: Frontend.WebAdminAssignee: Andrej Krejcir <akrejcir>
Status: CLOSED CURRENTRELEASE QA Contact: meital avital <mavital>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.3.0CC: akrejcir, bugs, michal.skrivanek, rbarry
Target Milestone: ovirt-4.3.0Keywords: ZStream
Target Release: 4.3.0Flags: rule-engine: ovirt-4.3+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.3.0_alpha Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 1660055 (view as bug list) Environment:
Last Closed: 2019-02-13 07:43:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1660055    
Attachments:
Description Flags
screen video none

Description meital avital 2018-10-29 12:53:31 UTC 
Description of problem:
when editing VM -> resource allocation -> "IO Thread Enabled" text box, it is possible to enter an illegal value (any character and any number bigger than 127) value and click OK. after clicking OK, the dialog is closed but the new value is not saved.

Version-Release number of selected component (if applicable):
ovirt-engine-4.3.0-0.0.master.20181028124607.git19414bc.el7
vdsm-4.30.1-29.gitcbdbee9.el7.x86_64
libvirt-client-4.5.0-10.el7.x86_64
qemu-kvm-common-ev-2.10.0-21.el7_5.7.1.x86_64


How reproducible:
100%

Steps to Reproduce:
1. Edit VM dialog -> resource allocation
2. Check the "IO Thread Enabled" checkbox
3. Enter an illegal value (for example: -fs@!j316839) in the textbox

Actual results:
The Edit VM dialog closed and didn't give any error that the value incorrect.

Expected results:
Should accept only positive integer value between 1-127
Action should be rejected if any other value is entered and dialog shouldn't be closed till legal value is entered.


Additional info:
Screen video attached.
Comment 1 meital avital 2018-10-29 12:55:58 UTC 
Created attachment 1498550 [details]
screen video
Comment 2 Michal Skrivanek 2018-10-29 15:11:12 UTC 
validation done wrong?
Comment 3 Andrej Krejcir 2018-10-29 16:53:25 UTC 
I think the validation in the UI is ignored. It can be seen in the video, that the textbox turns red, because the value fails validation, but the update operation continues anyway.

The wrong value is not sent to backend, as the parameter have to be an integer.
Comment 4 Andrej Krejcir 2018-10-31 11:18:25 UTC 
This is a duplicate of Bug 1455944 which was closed for capacity reasons.

We could write a workaround for this specific case, but it would not fix all the text boxes that expect integers.
Comment 5 meital avital 2018-11-21 15:04:34 UTC 
Verified on :
ovirt-engine-4.3.0-0.2.master.20181120211612.git51027b1.el7.noarch
Comment 11 Sandro Bonazzola 2019-02-13 07:43:21 UTC 
This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.