Bug 1644399

Summary: [v2v] Edit infrastructure mapping bombs out - renders blank page, when tried to edit mapping which has missing cluster/network/datastore
Product: Red Hat CloudForms Management Engine Reporter: Kedar Kulkarni <kkulkarn>
Component: V2VAssignee: Brett Thurber <bthurber>
Status: CLOSED CURRENTRELEASE QA Contact: Yadnyawalk Tale <ytale>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.10.0CC: akarol, dmetzger, fdupont, kkulkarn, mfeifer, simaishi, smallamp, ytale
Target Milestone: GAFlags: kkulkarn: automate_bug+
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: v2v
Fixed In Version: 5.10.0.27 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-12 16:50:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:
Bug Depends On: 1595365    
Bug Blocks: 1644443    
Attachments:
Description Flags
ScreenVideoRecording none

Description Kedar Kulkarni 2018-10-30 17:54:29 UTC
Created attachment 1499023 [details]
ScreenVideoRecording

Description of problem:
Watch the attached video, edit mapping yields blank page with issues in console. 

Version-Release number of selected component (if applicable):
5.10.0.21

How reproducible:
100%

Steps to Reproduce:
1.Add VMware/RHV providers
2.Create a few infrastructure mappings
3.Remove one of the providers and add it back 
4.Try to edit mappings for the infra mapping which has missing network or cluster or storage

Actual results:
watch the video attached, page goes blank, errors in console

Expected results:
Handle this situation gracefully, or disable edit mapping for these kind of infra mappings.

Additional info:

Comment 4 Kedar Kulkarni 2018-11-05 16:54:28 UTC
https://github.com/ManageIQ/manageiq-v2v/issues/749

Comment 6 CFME Bot 2018-11-27 20:57:46 UTC
New commit detected on ManageIQ/manageiq-v2v/master:

https://github.com/ManageIQ/manageiq-v2v/commit/2e1a75d68541fdcb0b7fe093f49051ba13ae89ee
commit 2e1a75d68541fdcb0b7fe093f49051ba13ae89ee
Author:     Mike Ro <mikerodev>
AuthorDate: Tue Nov 20 16:25:23 2018 -0500
Commit:     Mike Ro <mikerodev>
CommitDate: Tue Nov 20 16:25:23 2018 -0500

    Disable edit button for broken mappings

    If any clusters/datastores/networks that make up an infra mapping are
    missing from the database, disable the edit button.

    https://bugzilla.redhat.com/show_bug.cgi?id=1644399

 app/javascript/react/screens/App/Mappings/components/InfrastructureMappingsList/InfrastructureMappingsList.js | 4 +-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comment 7 CFME Bot 2018-11-28 15:12:58 UTC
New commit detected on ManageIQ/manageiq-v2v/hammer:

https://github.com/ManageIQ/manageiq-v2v/commit/430ca5fe40cd24455972dbe9411da35b3dfcf1d8
commit 430ca5fe40cd24455972dbe9411da35b3dfcf1d8
Author:     Mike Turley <mike.turley.umass.edu>
AuthorDate: Tue Nov 27 15:55:56 2018 -0500
Commit:     Mike Turley <mike.turley.umass.edu>
CommitDate: Tue Nov 27 15:55:56 2018 -0500

    Merge pull request #806 from michaelkro/749-disable-edit-button

    [#749] Disable edit button for broken mappings

    (cherry picked from commit 8a5d5103eae6a8f91e4d822e81a461166cf589cc)

    https://bugzilla.redhat.com/show_bug.cgi?id=1644399

 app/javascript/react/screens/App/Mappings/components/InfrastructureMappingsList/InfrastructureMappingsList.js | 4 +-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comment 9 Yadnyawalk Tale 2018-12-11 15:17:13 UTC
Discussed related things offline.
https://gitter.im/ManageIQ/v2v?at=5c0fbc9e33d9e11991b65391

With ^^ devel's fix, we are no longer supporting maps to be edited after step3, this is considered as a edge use case at the moment.
Thanks a lot @Brett and @Mike for explanations.