Bug 1645084

Summary: Container Review Request: origin-cli - origin-cli image
Product: [Fedora] Fedora Container Images Reporter: Jakub Čajka <jcajka>
Component: Container ReviewAssignee: Clement Verna <clems.verna>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: clems.verna, container-review
Target Milestone: ---Keywords: EasyFix
Target Release: ---Flags: clems.verna: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: origin-cli-3.11-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-01-22 14:11:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jakub Čajka 2018-11-01 11:51:57 UTC 
Container Build Info URL: https://pagure.io/origin-dockerfiles/blob/master/f/3.11/cli/Dockerfile
Description: One of base layered images for OpenShift Origin
Fedora Account System Username: jcajka
Comment 1 Clement Verna 2018-11-19 14:58:56 UTC 
The correct FROM line should be uncommented and the other one should be removed

# FROM registry.fedoraproject.org/f29/origin-base:latest

FROM origin-base

Should the com.redhat.component be origin-cli ? If left to origin koji will show the build as origin builds.

The usage label should provide an example of container execution
Comment 2 Jakub Čajka 2018-11-19 15:17:21 UTC 
(In reply to Clement Verna from comment #1)
> The correct FROM line should be uncommented and the other one should be
> removed
> 
> # FROM registry.fedoraproject.org/f29/origin-base:latest
> 
> FROM origin-base

Know, this is to enable integration with other image on the local machine.

> 
> Should the com.redhat.component be origin-cli ? If left to origin koji will
> show the build as origin builds.

Fixed.

> 
> The usage label should provide an example of container execution

I would rather stick to the upstream usage, although it is kind of vague it captures the intended usage well(as the upstream is kind of vague on its own...).
Comment 3 Clement Verna 2018-11-19 15:20:48 UTC 
Ok thanks for the answers

Look good to me
Comment 4 Gwyn Ciesla 2018-11-21 14:19:21 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/container/origin-cli