Bug 1645084 - Container Review Request: origin-cli - origin-cli image
Summary: Container Review Request: origin-cli - origin-cli image
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora Container Images
Classification: Fedora
Component: Container Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Clement Verna
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-01 11:51 UTC by Jakub Čajka
Modified: 2019-01-22 14:11 UTC (History)
2 users (show)

Fixed In Version: origin-cli-3.11-1
Clone Of:
Environment:
Last Closed: 2019-01-22 14:11:29 UTC
Type: Bug
Embargoed:
clems.verna: fedora-review+


Attachments (Terms of Use)

Description Jakub Čajka 2018-11-01 11:51:57 UTC
Container Build Info URL: https://pagure.io/origin-dockerfiles/blob/master/f/3.11/cli/Dockerfile
Description: One of base layered images for OpenShift Origin
Fedora Account System Username: jcajka

Comment 1 Clement Verna 2018-11-19 14:58:56 UTC
The correct FROM line should be uncommented and the other one should be removed

# FROM registry.fedoraproject.org/f29/origin-base:latest

FROM origin-base

Should the com.redhat.component be origin-cli ? If left to origin koji will show the build as origin builds.

The usage label should provide an example of container execution

Comment 2 Jakub Čajka 2018-11-19 15:17:21 UTC
(In reply to Clement Verna from comment #1)
> The correct FROM line should be uncommented and the other one should be
> removed
> 
> # FROM registry.fedoraproject.org/f29/origin-base:latest
> 
> FROM origin-base

Know, this is to enable integration with other image on the local machine.

> 
> Should the com.redhat.component be origin-cli ? If left to origin koji will
> show the build as origin builds.

Fixed.

> 
> The usage label should provide an example of container execution

I would rather stick to the upstream usage, although it is kind of vague it captures the intended usage well(as the upstream is kind of vague on its own...).

Comment 3 Clement Verna 2018-11-19 15:20:48 UTC
Ok thanks for the answers

Look good to me

Comment 4 Gwyn Ciesla 2018-11-21 14:19:21 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/container/origin-cli


Note You need to log in before you can comment on or make changes to this bug.