Bug 1645400
| Summary: | gcc miscompiles bitset code in mesa | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dave Airlie <airlied> |
| Component: | gcc | Assignee: | Jakub Jelinek <jakub> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 28 | CC: | airlied, aoliva, carl, davejohansen, dmalcolm, ego.cordatus, fweimer, jakub, jwakely, law, madcatx, mcatanzaro+wrong-account-do-not-cc, mpolacek, msebor, nickc, zebob.m |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | gcc-8.2.1-5.fc29 gcc-8.2.1-5.fc28 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-11-09 06:03:27 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
8.2.1-whatexactly vs. 8.0.1-whatexactly? Can you please provide a preprocessed source + full gcc/g++ command line for the corresponding file? Note, as a workaround most likely -fno-store-merging should work. Actually, reproduced it myself even without preprocessed source:
struct S {
union F {
struct T {
#define A(n) unsigned n:1;
#define B(n) A(n##0) A(n##1) A(n##2) A(n##3) A(n##4) A(n##5) A(n##6) A(n##7) A(n##8) A(n##9)
B(f) B(f1) B(f2) B(f3) B(f4) B(f5) A(f60) A(f61) A(f62) A(f63) A(f64) A(f65) A(f66)
} q;
unsigned int i[3];
} f;
};
__attribute__((noipa)) void
bar (unsigned *x)
{
if (x[0] != 0x002be3e7)
__builtin_abort ();
}
__attribute__((noipa)) void
foo (unsigned char *state)
{
struct S i;
i.f.i[0] = 0; i.f.i[1] = 0; i.f.i[2] = 0; i.f.q.f7 = 1; i.f.q.f2 = 1; i.f.q.f21 = 1;
i.f.q.f19 = 1; i.f.q.f14 = 1; i.f.q.f5 = 1; i.f.q.f0 = 1; i.f.q.f15 = 1; i.f.q.f16 = 1;
i.f.q.f6 = 1; i.f.q.f9 = 1; i.f.q.f17 = 1; i.f.q.f1 = 1; i.f.q.f8 = 1; i.f.q.f13 = 1;
i.f.q.f66 = 1;
if (*state)
{
i.f.q.f37 = 1; i.f.q.f38 = 1; i.f.q.f39 = 1; i.f.q.f40 = 1; i.f.q.f41 = 1; i.f.q.f36 = 1;
}
bar (i.f.i);
}
int
main ()
{
unsigned char zero = 0;
foo (&zero);
return 0;
}
Started with my http://gcc.gnu.org/r264232 . *** Bug 1645850 has been marked as a duplicate of this bug. *** gcc-8.2.1-5.fc{28,29,30} which should fix this is building in koji.
Igor, maybe you could get a buildroot override to speed up the process of releasing a fixed mesa? Because arm 32-bit is extremely slow, the gcc builds usually take a day or so, so should finish probably tomorrow noon in Europe or so. That said, f29 x86_64 rpm is built, so if somebody wants to test it out outside of koji, it is possible manually: https://koji.fedoraproject.org/koji/taskinfo?taskID=30689762 gcc-8.2.1-5.fc{28,29,30} built fine, is in f30 now, before filing bodhi erratas for f28/f29 I'd like to hear that it actually resolved the mesa issues. Can anyone please verify that?
Recompiled Mesa 18.2.4 locally with this new GCC and the bug #1645850 is solved. Playback with mpv is fine and without shaders issues anymore. gcc-8.2.1-5.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-de93530d49 gcc-8.2.1-5.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-cd24e05681 gcc-8.2.1-5.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-de93530d49 gcc-8.2.1-5.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-cd24e05681 gcc-8.2.1-5.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. gcc-8.2.1-5.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: Some recent gcc push (at least 8.2.1 is broken, 8.0.1 seems okay) I can bisect further next week, breaks mesa compilation of a bunch of bitfields. Broken asm: input_layout_mask.flags.q.precise = 1; input_layout_mask.flags.q.sample = 1; input_layout_mask.flags.q.smooth = 1; input_layout_mask.flags.q.non_coherent = 1; if (state->has_bindless()) { 203: 80 ba d6 02 00 00 00 cmpb $0x0,0x2d6(%rdx) 20a: 48 c7 44 24 40 00 00 movq $0x60000000,0x40(%rsp) 211: 00 60 213: c7 44 24 48 00 00 00 movl $0x0,0x48(%rsp) 21a: 00 21b: c7 84 24 10 01 00 00 movl $0x1e000000,0x110(%rsp) 222: 00 00 00 1e 226: c7 84 24 e0 01 00 00 movl $0xc00000,0x1e0(%rsp) 22d: 00 00 c0 00 231: c7 84 24 b4 02 00 00 movl $0x2000,0x2b4(%rsp) 238: 00 20 00 00 23c: 48 c7 84 24 80 03 00 movq $0x2840a5,0x380(%rsp) 243: 00 a5 40 28 00 Original asm: 203: 80 ba d6 02 00 00 00 cmpb $0x0,0x2d6(%rdx) 20a: 48 c7 44 24 40 00 00 movq $0x60000000,0x40(%rsp) 211: 00 60 213: c7 44 24 48 00 00 00 movl $0x0,0x48(%rsp) 21a: 00 21b: c7 84 24 10 01 00 00 movl $0x1e000000,0x110(%rsp) 222: 00 00 00 1e 226: c7 84 24 e0 01 00 00 movl $0xc00000,0x1e0(%rsp) 22d: 00 00 c0 00 231: c7 84 24 b4 02 00 00 movl $0x2000,0x2b4(%rsp) 238: 00 20 00 00 23c: 48 c7 84 24 80 03 00 movq $0x2be3e7,0x380(%rsp) 243: 00 e7 e3 2b 00 Note the change in 23c movq value. The code in question is https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/compiler/glsl/ast_type.cpp#L254 I intend to dig a bit more next week, but I'd thought I'd at least give a headsup and file a bug.