Bug 1645768 (python-duecredit)
| Summary: | Review Request: python-duecredit - Automated collection and reporting of citations for used software/methods/datasets | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-11-15 02:12:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1276941 | ||
|
Description
Ankur Sinha (FranciscoD)
2018-11-03 13:52:11 UTC
Forgot the spec/srpm links: https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit.spec https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit-0.6.4-1.fc29.src.rpm *** Bug 1645767 has been marked as a duplicate of this bug. *** > %global _description %{expand: Nice trick. Please add a backslash at the end of this line, because otherwise there's an spurious empty line in each "Description" section. > %description doc > %{_description} Suggestion: maybe just say "documentation for %name". rpmlint: > python3-duecredit.noarch: E: summary-too-long C Automated collection and reporting of citations for used software/methods/datasets Yeah, please fix. + package name is OK + license is acceptable (BSD) + license is specified correctly + latest version + builds and installs OK + fedora-review finds no issues + BR/Requires/Provides look OK Package is APPROVED. Thank you for the quick review, Zbigniew. (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > > %global _description %{expand: > Nice trick. Stole if from another spec I saw ;) > > Please add a backslash at the end of this line, because otherwise there's an > spurious empty line in each "Description" section. Done. > > > %description doc > > %{_description} > Suggestion: maybe just say "documentation for %name". Done > > rpmlint: > > python3-duecredit.noarch: E: summary-too-long C Automated collection and reporting of citations for used software/methods/datasets > > Yeah, please fix. > Done. > + package name is OK > + license is acceptable (BSD) > + license is specified correctly > + latest version > + builds and installs OK > + fedora-review finds no issues > + BR/Requires/Provides look OK > > Package is APPROVED. Thanks. Here is the updated spec/srpm: https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit.spec https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit-0.6.4-2.fc29.src.rpm Requesting scm now. Cheers, Ankur (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-duecredit python-duecredit-0.6.4-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c659fbecc6 python-duecredit-0.6.4-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a61ca72ac6 python-duecredit-0.6.4-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-af26dc28f1 python-duecredit-0.6.4-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c659fbecc6 python-duecredit-0.6.4-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-af26dc28f1 python-duecredit-0.6.4-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a61ca72ac6 python-duecredit-0.6.4-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. python-duecredit-0.6.4-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. python-duecredit-0.6.4-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |