Bug 1647999

I have a srpm to build libgpod-sharp as a part of epel (it was removed when libgpod became a part of rhel).
The spec is ready for a first review of a packager, but we need to add the new package to git.

Can you put the link to the review request for libgpod-sharp to this bug so we can track it, and/or have a packager review it.

Created attachment 1515578 [details]
libgpod-sharp PoC

libgpod-sharp.spec PoC
It is basically a mix of libgpod from rhel and the last released in epel

The spec file looks good.  It builds and installs on RHEL7/EPEL7.

Hi Pablo,
Do you have a review request or anything like that for libgpod-sharp?
Since this is an EPEL package that won't be in Fedora, I guess you would follow what is here
https://fedoraproject.org/wiki/EPEL/FAQ#Is_it_possible_to_get_a_package_only_into_EPEL_and_not_Fedora.3F
Basically you go through the review process for Fedora and specify only EL targets for the initial import.

Any progress on this?
Could I create libgpod-sharp in EPEL7?  Yes
But that would mean that I own it, and I don't want to own it because I don't use it.

The following builds on EPEL7 and installs on RHEL/CentOS/SL 7.
Here is a scratch build with this change
https://koji.fedoraproject.org/koji/taskinfo?taskID=34104828

Are people ok with me doing this?
I figure it's better than not installing at all.
And if someone ever builds libgpod-sharp for RHEL7, this can be updated back.

diff --git a/banshee.spec b/banshee.spec
index fb391a5..4181849 100644
--- a/banshee.spec
+++ b/banshee.spec
@@ -1,6 +1,6 @@
 Name:    banshee
 Version: 2.6.2
-Release: 11%{?dist}
+Release: 11.1%{?dist}
 Summary: Easily import, manage, and play selections from your music collection
 
 License: MIT
@@ -20,8 +20,8 @@ Patch7: banshee-2.6.2-gst1.0-handle-events-fix.patch
 # https://bugzilla.gnome.org/show_bug.cgi?id=740879
 Patch8: banshee-2.6.2-sqlite-hints.patch
 
-# Mono only available on these:
-ExclusiveArch: %{mono_arches}
+# Mono only available on these arches for rhel7
+ExclusiveArch: x86_64 ppc64
 
 BuildRequires: mono-devel
 BuildRequires: mono-zeroconf-devel >= 0.9.0-2
@@ -36,16 +36,22 @@ BuildRequires: dbus-glib-devel
 BuildRequires: GConf2-devel
 
 # Web Browser
-BuildRequires: webkitgtk-devel
+# OLD webkitgtk1 is dead.
+# BuildRequires: webkitgtk-devel
+# But we still need gtk2-devel
+BuildRequires: gtk2-devel
 
 # Sharp
 BuildRequires: gio-sharp-devel gtk-sharp-beans-devel
 BuildRequires: gkeyfile-sharp-devel gudev-sharp-devel
 BuildRequires: gtk-sharp2-devel taglib-sharp-devel
 BuildRequires: gnome-sharp-devel notify-sharp-devel
+# libgpod-sharp-devel not in RHEL or EPEL
+%if 0%{?fedora}
 %ifnarch s390 s390x
 BuildRequires: libgpod-sharp-devel >= 0.8.2
 %endif
+%endif
 BuildRequires: gdata-sharp-devel
 BuildRequires: dbus-sharp-devel >= 1:0.7.0
 BuildRequires: dbus-sharp-glib-devel
@@ -75,10 +81,12 @@ BuildRequires: autoconf automake libtool
 
 Requires:      shared-mime-info
 Requires:      gstreamer1-plugins-good
+%if 0%{?fedora}
 %ifnarch s390 s390x
 Requires:      libgpod-sharp >= 0.8.2
 Requires:      gvfs-afc
 %endif
+%endif
 Requires:      gio-sharp gtk-sharp-beans
 Requires:      media-player-info
 
@@ -130,7 +138,7 @@ sed -i "s#mono/2.0#mono/4.5#g" configure
 sed -i "s#Mono 2.0#Mono 4.5#g" configure
 
 %configure  --disable-docs --enable-mtp \
-%ifarch s390 s390x
+%if 0%{?rhel}
             --disable-appledevice \
 %endif
             --with-vendor-build-id=Fedora%{?fedora}-%{version}-%{release} \
@@ -195,6 +203,9 @@ update-mime-database %{?fedora:-n} %{_datadir}/mime &> /dev/null || :
 %{_libdir}/pkgconfig/banshee-*.pc
 
 %changelog
+* Wed Apr 10 2019 Troy Dawson <tdawson> - 2.6.2-11.1
+- Remove libipod-sharp dependencies (#1647999)
+
 * Fri Feb 12 2016 Tom Callaway <spot> - 2.6.2-11
 - fixup sqlite hints patch to do proper version checking and match upstream commit

banshee-2.6.2-11.1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-3eed2a4655

*** Bug 1406012 has been marked as a duplicate of this bug. ***

*** Bug 1589490 has been marked as a duplicate of this bug. ***

banshee-2.6.2-11.1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-3eed2a4655

banshee-2.6.2-11.2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-3eed2a4655

banshee-2.6.2-11.2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-3eed2a4655

banshee-2.6.2-11.2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment on attachment 1515578 [details]
libgpod-sharp PoC

closing review

Comment on attachment 1515578 [details]
libgpod-sharp PoC

Approve