Bug 1648251 (python-petlink)
| Summary: | Review Request: python-petlink - Decode and encode Petlink data streams (32 and 64 bit) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
| Component: | Package Review | Assignee: | Miro Hrončok <mhroncok> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mhroncok, package-review |
| Target Milestone: | --- | Flags: | mhroncok:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-11-18 02:57:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1276941 | ||
|
Description
Ankur Sinha (FranciscoD)
2018-11-09 08:58:58 UTC
Rawhide build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30750651 F28/29 require buildroot overrides for the python-simplewrap update. I'd personally use:
cp -v %{SOURCE1} LICENSE
...
%license LICENSE
Other than that, the spec looks OK, running checks.
Thanks, Miro. I've updated the spec/srpm to do so: Spec URL: https://ankursinha.fedorapeople.org/python-petlink/python-petlink.spec SRPM URL: https://ankursinha.fedorapeople.org/python-petlink/python-petlink-0.3.2-1.fc29.src.rpm * Fri Nov 09 2018 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.3.2-1 - Rename license file to LICENSE as per reviewer suggestion Cheers, Ankur OK. It builds, no rpmlint issues found, license checks, package approved ;) (I cannot use fedora-review tool now, but I've checked all the things important.) Thanks for the quick review, Miro. SCM requested: https://pagure.io/releng/fedora-scm-requests/issue/8761 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-petlink python-petlink-0.3.2-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fc72346d60 python-petlink-0.3.2-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-86f067b027 python-petlink-0.3.2-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5e77c7716f python-petlink-0.3.2-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-fc72346d60 python-petlink-0.3.2-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-86f067b027 python-petlink-0.3.2-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5e77c7716f python-petlink-0.3.2-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. python-petlink-0.3.2-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. python-petlink-0.3.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |