Bug 1648625
| Summary: | Removal of one of the snapshot memory disks (memory / metadata) will cause a failure to create/update storage domain OVF | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Eyal Shenitzky <eshenitz> | ||||
| Component: | BLL.Storage | Assignee: | Eyal Shenitzky <eshenitz> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Shir Fishbain <sfishbai> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 4.3.0 | CC: | bugs, eshames, eshenitz, rbarry, tnisan | ||||
| Target Milestone: | ovirt-4.2.8 | Keywords: | Regression | ||||
| Target Release: | --- | Flags: | rule-engine:
ovirt-4.2+
rule-engine: blocker+ |
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: |
Cause:
Removal of one of the VM snapshot memory disks will cause problems in other flows (for e.g updating domain OVF)
Fix:
When removing one of the snapshot memory disk the other disk will remove also.
Result:
Both memory disks removed when removing one of the snapshot memory disk
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2019-01-22 10:23:05 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Eyal, I assume this a regression, right? Evelina, please check if it occurs also with 4.2.7 No need. It will occur in 4.2.7 also. Thanks Eyal, can you please clone it for 4.2.7? This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP. Same comment as email, but it seems like the flexibility/visibility gained by exposing these to users is not worth the risk. Why not hide them? Verified The storage domain deactivation succeeded ovirt-engine-4.2.8.2-0.1.el7ev.noarch vdsm-4.20.46-1.el7ev.x86_64 2019-01-13 19:21:10,524+02 INFO [org.ovirt.engine.core.bll.storage.domain.DetachStorageDomainFromPoolCommand] (EE-ManagedThreadFactory-engine-Thread-51177) [7bbb8063-e6bf-4676-a6d9-6731d0b7e0fc] End detach storage domain 2019-01-13 19:21:10,538+02 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-engine-Thread-51177) [7bbb8063-e6bf-4676-a6d9-6731d0b7e0fc] EVENT_ID: USER_DETACH_ STORAGE_DOMAIN_FROM_POOL(964), Storage Domain My_ISCSI was detached from Data Center golden_env_mixed by admin@internal-authz This bugzilla is included in oVirt 4.2.8 release, published on January 22nd 2019. Since the problem described in this bug report should be resolved in oVirt 4.2.8 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Created attachment 1504291 [details] engine log Description of problem: When creating a live snapshot with memory, the engine creates 2 disks that are visible to the user, snapshot_memory and snapshot_metadata. On those disks, the user can perform all the operations that can be done on a regular disk for example - remove and move. If only one of those disks is missing (removed or moved to a storage domain that detached later for example), the creation/update of the OVF for the VM that use those disks will fail. Currently, the engine works under the assumption that if of the disks exists it means that both of them exist, and this is not true after the exposure of the memory disks to the user. Version-Release number of selected component (if applicable): 4.3 - commit 2863cec4c92e9fa7e09486ebc0649ec537d53967 Relevant also to 4.2.7 How reproducible: 100% Steps to Reproduce: 1. Create a VM with a disk on storage domain A 2. Run the VM 3. Create a snapshot with memory 4. Power off the VM 5. Remove one of the snapshot memory disks (memory/metadata) 6. Try to deactivate storage domain A Actual results: Storage domain A deactivation will fail due to OVF update failure Expected results: Storage domain A deactivation should succeed Additional info: