Bug 1648625 - Removal of one of the snapshot memory disks (memory / metadata) will cause a failure to create/update storage domain OVF
Summary: Removal of one of the snapshot memory disks (memory / metadata) will cause a ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.2.8
: ---
Assignee: Eyal Shenitzky
QA Contact: Shir Fishbain
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-11-11 07:04 UTC by Eyal Shenitzky
Modified: 2019-01-22 10:23 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Removal of one of the VM snapshot memory disks will cause problems in other flows (for e.g updating domain OVF) Fix: When removing one of the snapshot memory disk the other disk will remove also. Result: Both memory disks removed when removing one of the snapshot memory disk
Clone Of:
Environment:
Last Closed: 2019-01-22 10:23:05 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: blocker+


Attachments (Terms of Use)
engine log (2.17 MB, application/zip)
2018-11-11 07:04 UTC, Eyal Shenitzky
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 96202 0 master MERGED core: remove memory/metadata snapshot disk will remove metadata/memory disk also 2018-12-17 08:45:07 UTC
oVirt gerrit 96261 0 ovirt-engine-4.2 MERGED core: remove memory/metadata snapshot disk will remove metadata/memory disk also 2018-12-18 12:37:08 UTC

Description Eyal Shenitzky 2018-11-11 07:04:29 UTC
Created attachment 1504291 [details]
engine log

Description of problem:

When creating a live snapshot with memory, the engine creates 2 disks that are visible to the user, snapshot_memory and snapshot_metadata.

On those disks, the user can perform all the operations that can be done on a regular disk for example - remove and move.

If only one of those disks is missing (removed or moved to a storage domain that detached later for example), the creation/update of the OVF for the VM that use those disks will fail.
 
Currently, the engine works under the assumption that if of the disks exists it means that both of them exist, and this is not true after the exposure of the memory disks to the user.


Version-Release number of selected component (if applicable):
4.3 - commit 2863cec4c92e9fa7e09486ebc0649ec537d53967
Relevant also to 4.2.7

How reproducible:
100%

Steps to Reproduce:
1. Create a VM with a disk on storage domain A
2. Run the VM
3. Create a snapshot with memory
4. Power off the VM 
5. Remove one of the snapshot memory disks (memory/metadata)
6. Try to deactivate storage domain A

Actual results:
Storage domain A deactivation will fail due to OVF update failure

Expected results:
Storage domain A deactivation should succeed

Additional info:

Comment 1 Elad 2018-11-11 08:03:10 UTC
Eyal, I assume this a regression, right?

Comment 2 Elad 2018-11-11 08:30:45 UTC
Evelina, please check if it occurs also with 4.2.7

Comment 3 Eyal Shenitzky 2018-11-11 08:34:14 UTC
No need.

It will occur in 4.2.7 also.

Comment 4 Elad 2018-11-11 08:36:54 UTC
Thanks Eyal, can you please clone it for 4.2.7?

Comment 5 Red Hat Bugzilla Rules Engine 2018-11-11 08:40:54 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 6 Ryan Barry 2018-11-13 03:04:10 UTC
Same comment as email, but it seems like the flexibility/visibility gained by exposing these to users is not worth the risk. Why not hide them?

Comment 7 Shir Fishbain 2019-01-13 18:25:43 UTC
Verified
The storage domain deactivation succeeded

ovirt-engine-4.2.8.2-0.1.el7ev.noarch
vdsm-4.20.46-1.el7ev.x86_64

2019-01-13 19:21:10,524+02 INFO  [org.ovirt.engine.core.bll.storage.domain.DetachStorageDomainFromPoolCommand] (EE-ManagedThreadFactory-engine-Thread-51177) [7bbb8063-e6bf-4676-a6d9-6731d0b7e0fc] End detach storage domain
2019-01-13 19:21:10,538+02 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (EE-ManagedThreadFactory-engine-Thread-51177) [7bbb8063-e6bf-4676-a6d9-6731d0b7e0fc] EVENT_ID: USER_DETACH_
STORAGE_DOMAIN_FROM_POOL(964), Storage Domain My_ISCSI was detached from Data Center golden_env_mixed by admin@internal-authz

Comment 8 Sandro Bonazzola 2019-01-22 10:23:05 UTC
This bugzilla is included in oVirt 4.2.8 release, published on January 22nd 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.2.8 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.