Bug 1648893

Summary:	statedump doesn't contain information about newer mempools
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Raghavendra G <rgowdapp>
Component:	core	Assignee:	Sunny Kumar <sunkumar>
Status:	CLOSED ERRATA	QA Contact:	Sayalee <saraut>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rhgs-3.4	CC:	amukherj, atumball, bkunal, moagrawa, nbalacha, nchilaka, ndevos, rhs-bugs, sanandpa, sankarshan, saraut, sheggodu, storage-qa-internal, sunkumar
Target Milestone:	---	Keywords:	ZStream
Target Release:	RHGS 3.4.z Batch Update 3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.12.2-34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-04 07:41:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1647277, 1649191

Description Raghavendra G 2018-11-12 11:56:32 UTC

Description of problem:

We have moved to newer implementation of mem-pools. But statedump doesn't print the information about them. Github issue [1] captures upstream effort on this. But preliminary reading shows the work still has some parts to be completed. So, the effort includes:

* backporting https://review.gluster.org/18076
* reviewing whether the information printed by above patch is complete from the perspective of debugging memory consumption issues.

[1] https://github.com/gluster/glusterfs/issues/307


Version-Release number of selected component (if applicable):
3.4.0

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 4 Amar Tumballi 2018-11-19 05:09:05 UTC

Patch is already available upstream.

Comment 5 Raghavendra G 2018-11-26 14:23:32 UTC

(In reply to Amar Tumballi from comment #4)
> Patch is already available upstream.

If you are speaking about https://review.gluster.org/18076, we still need to evaluate whether it covers all aspects of newer memory pools. So, the work may not be complete

Comment 9 Raghavendra G 2018-12-11 05:09:27 UTC

https://review.gluster.org/#/c/glusterfs/+/18075/ is needed too.

Comment 10 Raghavendra G 2018-12-11 05:23:05 UTC

commit msg of one of patches [1] say - This only captures the information from 'struct mem_pool', and not from the global 'struct mem_pool_shared' or the pool_sweeper thread. The current details help with detecting memory leaks.


so we need to find out what is left out if we don't dump those fields and preferably add those two fields if important. 

[1] https://review.gluster.org/18076

Comment 32 Sayalee 2019-01-08 11:33:11 UTC

Based on the points discussed in #comment28,#comment30 and #comment31 , moving this bug to verified.

Comment 34 errata-xmlrpc 2019-02-04 07:41:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0263