Bug 1649527

Summary:	Incorrect entities displayed in service dialog tag control options modal
Product:	Red Hat CloudForms Management Engine	Reporter:	Mike Shriver <mshriver>
Component:	UI - OPS	Assignee:	Martin Povolny <mpovolny>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Shveta <sshveta>
Severity:	low	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	high
Version:	5.10.0	CC:	bmidwood, dmetzger, duhlmann, hkataria, jprause, lavenel, mfeifer, mpovolny, obarenbo, simaishi
Target Milestone:	GA	Keywords:	Regression
Target Release:	5.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	testathon:ui:service;dialog
Fixed In Version:	5.10.0.31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-12 16:52:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:

Description Mike Shriver 2018-11-13 19:30:56 UTC

Description of problem:
The modal for the tag control widget on a service dialog displays the wrong entities list for the selected catalog


Version-Release number of selected component (if applicable):
5.10.0.22.20181030184024_26956a0

How reproducible:
100%

Steps to Reproduce:
1. Create new service dialog, or edit existing
2. Include tag control widget in the form
3. View tag control options
4. On resulting modal, go to 'Options' tab
5. Note entities list is already populated with locations
6. select 'Location' for category
7. Note workloads are listed in entities

Actual results:
The entities list on the modal displays the _next_ category in the list instead of the currently selected one

Expected results:
The relevant entities for the selected catalog are displayed

Additional info:

Comment 5 drew uhlmann 2018-12-07 20:03:29 UTC

Looks like a UI issue to me, there's a JS console error present.

Comment 6 Martin Povolny 2018-12-12 14:04:37 UTC

https://github.com/ManageIQ/ui-components/pull/new/fix_tag_control_entries

Comment 7 CFME Bot 2018-12-12 14:12:37 UTC

https://github.com/ManageIQ/ui-components/pull/358

Comment 8 CFME Bot 2018-12-12 15:14:14 UTC

New commit detected on ManageIQ/ui-components/master:

https://github.com/ManageIQ/ui-components/commit/9722cdf1163be1e36dd5a550bc020cc1433ea521
commit 9722cdf1163be1e36dd5a550bc020cc1433ea521
Author:     Martin Povolny <mpovolny>
AuthorDate: Wed Dec 12 09:02:56 2018 -0500
Commit:     Martin Povolny <mpovolny>
CommitDate: Wed Dec 12 09:02:56 2018 -0500

    Fix lodash "find" call in currentCategoryEntries.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649527

 src/dialog-editor/components/modal/modalComponent.ts | 5 +-
 1 file changed, 3 insertions(+), 2 deletions(-)

Comment 10 CFME Bot 2018-12-13 14:54:37 UTC

New commit detected on ManageIQ/ui-components/hammer:

https://github.com/ManageIQ/ui-components/commit/d312e4e7fb58f40c76b4b018e7591148829fa2a9
commit d312e4e7fb58f40c76b4b018e7591148829fa2a9
Author:     Martin Hradil <himdel>
AuthorDate: Wed Dec 12 10:08:31 2018 -0500
Commit:     Martin Hradil <himdel>
CommitDate: Wed Dec 12 10:08:31 2018 -0500

    Merge pull request #358 from ManageIQ/fix_tag_control_entries

    Fix lodash "find" call in currentCategoryEntries.

    (cherry picked from commit 0ab3d77f20f18ee14d621e09090342dbbc3d671d)

    https://bugzilla.redhat.com/show_bug.cgi?id=1649527

 src/dialog-editor/components/modal/modalComponent.ts | 5 +-
 1 file changed, 3 insertions(+), 2 deletions(-)

Comment 12 Martin Povolny 2019-01-03 16:28:34 UTC

Relevant PRs (merged)

https://github.com/ManageIQ/manageiq-ui-service/pull/1515
https://github.com/ManageIQ/manageiq-ui-classic/pull/5109

Comment 13 Mike Shriver 2019-01-09 23:26:21 UTC

Tested in CFME 5.10.0.31.20190108221820_a0968c8

The service dialog tag control modal now lists the correct entities for the selected category