Bug 1649720

Summary:	Unlimited setting for filter does not get rendered in the UI
Product:	Red Hat Satellite	Reporter:	Peter Ondrejka <pondrejk>
Component:	Users & Roles	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED NOTABUG	QA Contact:	Radovan Drazny <rdrazny>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	6.5.0	CC:	dhlavacd, mhulan, pondrejk
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-21 09:33:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Peter Ondrejka 2018-11-14 11:00:21 UTC

Description of problem:
Setting a filter to Unlimited completes successfully in the UI but afterwards the setting is not marked in the filters table and when revisiting the filter details the Unlimited checkbox is unchecked. 

Version-Release number of selected component (if applicable):
Sat 6.5 snap 8

How reproducible:
always

Steps to Reproduce:
1. create a custom role
2. add filter, set resource type and permission. If Unlimited is checked by default, uncheck it manually, then check it again.
3. Submit

Actual results:
The role's filters table shows Unlimited as unchecked, when editing the filter the checkbox is unchecked.


Additional info:
Does not apply to the Override checkbox

Comment 2 Marek Hulan 2018-11-14 12:41:56 UTC

Is the role or filter assigned to some organization/location? Is this a 6.5 regression?

Comment 3 Peter Ondrejka 2019-01-28 10:29:41 UTC

Checked again on 6.5 snap 13. It is reproducible only if role is assigned to one or more organizations, location setting does not have an effect. Looking at 6.4 Satellite I can reproduce the same problem.

Comment 4 Marek Hulan 2019-11-21 09:33:21 UTC

This is expected behavior, per the inline help:

"If the unlimited field is enabled, the filter applies to all resources of the selected type. If the unlimited field is disabled, you can specify further filtering using Foreman search syntax in the search field.> If the role is associated with organizations or locations, the filters are not considered unlimited as they are scoped accordingly."

The most important here to notice here, if filter are associated with some org/log, they are limited. The experience has changed  over last few versions a bit, since we encourage people to assign org/locs to the role. So there may be another RFE that will rename that checkbox or change the logic in showing the checkmark, but I'm closing this as NOTABUG. Please reopen if I missed something.