Bug 1649750 (python-pyemd)
| Summary: | Review Request: python-pyemd - Fast EMD for Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-11-25 02:02:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1276941, 1619458 | ||
|
Description
Ankur Sinha (FranciscoD)
2018-11-14 12:45:35 UTC
> BuildRequires: gcc gcc-c++ One-per-line please. > export PYTHONPATH=$RPM_BUILD_ROOT/%{python2_sitearch} I think %{buildroot} is nowadays considered nicer, but this is acceptable of course. + package name is OK + latest version + license is acceptable for Fedora (MIT) + licencse is specified correctly + builds and installs OK + fedora-review is happy + R/BR/P look OK Package is APPROVED. (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > > BuildRequires: gcc gcc-c++ > One-per-line please. > > > export PYTHONPATH=$RPM_BUILD_ROOT/%{python2_sitearch} > I think %{buildroot} is nowadays considered nicer, but this is acceptable of > course. > Thanks for the review, Zbigniew! Updated both. Spec URL: https://ankursinha.fedorapeople.org/python-pyemd/python-pyemd.spec SRPM URL: https://ankursinha.fedorapeople.org/python-pyemd/python-pyemd-0.5.1-1.fc29.src.rpm (Didn't bump the release for these, but noted in changelog) SCM requested: https://pagure.io/releng/fedora-scm-requests/issue/8834 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyemd python-pyemd-0.5.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9f668c47ec python-pyemd-0.5.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-12ea3cbd6f python-pyemd-0.5.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9f668c47ec python-pyemd-0.5.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-12ea3cbd6f python-pyemd-0.5.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. python-pyemd-0.5.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |