Bug 1649930

Summary:	Review Request: golang-gopkg-square-jose-2 - An implementation of JOSE standards (JWE, JWS, JWT) in Go
Product:	[Fedora] Fedora	Reporter:	Robert-André Mauchin 🐧 <zebob.m>
Component:	Package Review	Assignee:	Carl George <carl>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	carl, package-review
Target Milestone:	---	Flags:	carl: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-12-12 03:07:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robert-André Mauchin 🐧 2018-11-14 20:02:30 UTC

Spec URL: https://eclipseo.fedorapeople.org/golang-gopkg-square-jose.spec
SRPM URL: https://eclipseo.fedorapeople.org/golang-gopkg-square-jose-2-2.1.9-1.fc30.src.rpm

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30886568

Description:
Package jose aims to provide an implementation of the Javascript Object 
Signing and Encryption set of standards. This includes support for JSON Web 
Encryption, JSON Web Signature, and JSON Web Token standards.

Fedora Account System Username: eclipseo

Comment 1 Carl George 2018-11-14 21:08:56 UTC

Hello Robert!  I'll take a stab at reviewing this.  Please bear with me as I'm still fairly new to golang library packaging, and feel free to push back on anything I misunderstand.

The spec file name doesn't match the Name (golang-gopkg-square-jose vs golang-gopkg-square-jose-2) [0].

The code includes a CLI utility [1].  I think this should either be built and included, or have the source excluded from being installed in devel (`%goinstall -t jose-util`).

[0]: https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_File_Naming
[1]: https://github.com/square/go-jose/tree/v2.1.9/jose-util

Comment 2 Robert-André Mauchin 🐧 2018-11-14 22:40:40 UTC

You're right, i didn't notice the CLI tools.


Spec URL: https://eclipseo.fedorapeople.org/golang-gopkg-square-jose-2.spec
SRPM URL: https://eclipseo.fedorapeople.org/golang-gopkg-square-jose-2-2.1.9-1.fc30.src.rpm


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30889340

Comment 3 Robert-André Mauchin 🐧 2018-11-14 22:41:01 UTC

Thanks for the review!

Comment 4 Carl George 2018-11-15 21:46:53 UTC

I discovered a few other items.

Must fix:

The json directory contains a fork of the standard library json, which is BSD licensed.  Change the License field to `ASL 2.0 and BSD` and include json/LICENSE in %files.

The changelog entry still says 2.1.8 but the version is 2.1.9.

Optional fix:

The utility commands have their own README files (jose-util/README.md and jwk-keygen/README.md), I would consider including those in %files.  Of course they will have to be renamed (README-jose-util.md and README-jwk-keygen.md perhaps) to not overwrite the top level README.md.

Pending those fixes, PACKAGE APPROVED.

Comment 5 Gwyn Ciesla 2018-11-16 14:25:18 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-gopkg-square-jose-2

Comment 6 Fedora Update System 2018-11-16 22:57:20 UTC

golang-gopkg-square-jose-2-2.1.9-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-14a0164e68

Comment 7 Fedora Update System 2018-11-17 04:45:19 UTC

golang-gopkg-square-jose-2-2.1.9-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-14a0164e68

Comment 8 Fedora Update System 2018-12-12 03:07:44 UTC

golang-gopkg-square-jose-2-2.1.9-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.