Spec URL: https://eclipseo.fedorapeople.org/golang-gopkg-square-jose.spec SRPM URL: https://eclipseo.fedorapeople.org/golang-gopkg-square-jose-2-2.1.9-1.fc30.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30886568 Description: Package jose aims to provide an implementation of the Javascript Object Signing and Encryption set of standards. This includes support for JSON Web Encryption, JSON Web Signature, and JSON Web Token standards. Fedora Account System Username: eclipseo
Hello Robert! I'll take a stab at reviewing this. Please bear with me as I'm still fairly new to golang library packaging, and feel free to push back on anything I misunderstand. The spec file name doesn't match the Name (golang-gopkg-square-jose vs golang-gopkg-square-jose-2) [0]. The code includes a CLI utility [1]. I think this should either be built and included, or have the source excluded from being installed in devel (`%goinstall -t jose-util`). [0]: https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_File_Naming [1]: https://github.com/square/go-jose/tree/v2.1.9/jose-util
You're right, i didn't notice the CLI tools. Spec URL: https://eclipseo.fedorapeople.org/golang-gopkg-square-jose-2.spec SRPM URL: https://eclipseo.fedorapeople.org/golang-gopkg-square-jose-2-2.1.9-1.fc30.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30889340
Thanks for the review!
I discovered a few other items. Must fix: The json directory contains a fork of the standard library json, which is BSD licensed. Change the License field to `ASL 2.0 and BSD` and include json/LICENSE in %files. The changelog entry still says 2.1.8 but the version is 2.1.9. Optional fix: The utility commands have their own README files (jose-util/README.md and jwk-keygen/README.md), I would consider including those in %files. Of course they will have to be renamed (README-jose-util.md and README-jwk-keygen.md perhaps) to not overwrite the top level README.md. Pending those fixes, PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-gopkg-square-jose-2
golang-gopkg-square-jose-2-2.1.9-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-14a0164e68
golang-gopkg-square-jose-2-2.1.9-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-14a0164e68
golang-gopkg-square-jose-2-2.1.9-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.