Bug 1651322

Summary:	Incorrect usage of local->fd in afr_open_ftruncate_cbk
Product:	[Community] GlusterFS	Reporter:	Soumya Koduri <skoduri>
Component:	replicate	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	5	CC:	atumball, bugs
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-5.5	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1648687	Environment:
Last Closed:	2019-05-18 06:32:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1648687, 1655527, 1655578
Bug Blocks:

Description Soumya Koduri 2018-11-19 16:58:52 UTC

+++ This bug was initially created as a clone of Bug #1648687 +++

Description of problem:

afr_open() stores fd reference in local->cont.open structure. But in the callback function "afr_open_ftruncate_cbk" ( when openflags contain 'O_TRUNC' set), we reference local->fd in AFR_STACK_UNWIND resulting in error or crash.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Soumya Koduri on 2018-11-11 12:34:37 EST ---

Patch posted for review - https://review.gluster.org/#/c/glusterfs/+/21617/

--- Additional comment from Worker Ant on 2018-11-11 12:45:42 EST ---

REVIEW: https://review.gluster.org/21617 (afr: open_ftruncate_cbk should read fd from local->cont.open struct) posted (#2) for review on master by soumya k

--- Additional comment from Worker Ant on 2018-11-15 00:08:03 EST ---

REVIEW: https://review.gluster.org/21617 (afr: open_ftruncate_cbk should read fd from local->cont.open struct) posted (#8) for review on master by Ravishankar N

Comment 1 Worker Ant 2018-11-19 17:02:48 UTC

REVIEW: https://review.gluster.org/21677 (afr: open_ftruncate_cbk should read fd from local->cont.open struct) posted (#1) for review on release-5 by soumya k

Comment 2 Worker Ant 2018-11-29 15:35:21 UTC

REVIEW: https://review.gluster.org/21677 (afr: open_ftruncate_cbk should read fd from local->cont.open struct) posted (#2) for review on release-5 by Shyamsundar Ranganathan