Bug 1651502

Summary: [Disperse] : Set others.eager-lock on for ec-1468261.t test to pass
Product: [Community] GlusterFS Reporter: Ashish Pandey <aspandey>
Component: disperseAssignee: bugs <bugs>
Status: CLOSED NOTABUG QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 5CC: amukherj, bugs, jahernan, pkarampu
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1632161 Environment:
Last Closed: 2018-11-20 09:16:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1632161    
Bug Blocks:    

Description Ashish Pandey 2018-11-20 08:55:28 UTC
+++ This bug was initially created as a clone of Bug #1632161 +++

Description of problem:


tests/basic/ec/ec-1468261.t
In the above test we are relying on eager-lock time duration of 1 second to
delay the post op + unlock phase of entry fop so that in this 1 second we can kill 2 bricks and dirty on directory could be set.

However, we have set the others.eager-lock as OFF by default in out code. So this test is not getting 1 second delay in postop+unlock phase and so dirty flag is not getting set. In fact killing of brick is not impact at all on this fop.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Run the above test using prove
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Ashish Pandey on 2018-09-24 05:20:14 EDT ---

To fix this issue, we should set the others.eager-lock option to "ON" in the beginning of this test.

--- Additional comment from Worker Ant on 2018-09-24 05:26:05 EDT ---

REVIEW: https://review.gluster.org/21254 (cluster/ec: Fix failure of tests/basic/ec/ec-1468261.t) posted (#1) for review on master by Ashish Pandey

--- Additional comment from Worker Ant on 2018-09-25 09:58:25 EDT ---

COMMIT: https://review.gluster.org/21254 committed in master by "Xavi Hernandez" <xhernandez> with a commit message- cluster/ec: Fix failure of tests/basic/ec/ec-1468261.t

Problem:
In this test we are relying on eager-lock time
duration of 1 second to delay the post op + unlock phase
of an entry fop so that in this 1 second we can kill 2
bricks and dirty on directory could be set.

Solution:
To fix this issue, we should set the others.eager-lock
option to "ON" explicitly in the beginning of this test.

Change-Id: I19bbb9c15d7bdf96a96b20587c618192d0b740ef
fixes bz#1632161
Signed-off-by: Ashish Pandey <aspandey>

Comment 1 Worker Ant 2018-11-20 08:58:54 UTC
REVIEW: https://review.gluster.org/21690 (cluster/ec: Fix failure of tests/basic/ec/ec-1468261.t) posted (#1) for review on release-5 by Ashish Pandey

Comment 2 Ashish Pandey 2018-11-20 09:16:59 UTC

As we are not changing the default value of others.eager-lock to OFF,
there is no need of setting this option explicitly.