Bug 1632161 - [Disperse] : Set others.eager-lock on for ec-1468261.t test to pass
Summary: [Disperse] : Set others.eager-lock on for ec-1468261.t test to pass
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: disperse
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1651502
TreeView+ depends on / blocked
 
Reported: 2018-09-24 09:18 UTC by Ashish Pandey
Modified: 2019-03-25 16:30 UTC (History)
4 users (show)

Fixed In Version: glusterfs-6.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1651502 (view as bug list)
Environment:
Last Closed: 2018-11-20 08:58:13 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ashish Pandey 2018-09-24 09:18:39 UTC
Description of problem:


tests/basic/ec/ec-1468261.t
In the above test we are relying on eager-lock time duration of 1 second to
delay the post op + unlock phase of entry fop so that in this 1 second we can kill 2 bricks and dirty on directory could be set.

However, we have set the others.eager-lock as OFF by default in out code. So this test is not getting 1 second delay in postop+unlock phase and so dirty flag is not getting set. In fact killing of brick is not impact at all on this fop.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Run the above test using prove
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Ashish Pandey 2018-09-24 09:20:14 UTC
To fix this issue, we should set the others.eager-lock option to "ON" in the beginning of this test.

Comment 2 Worker Ant 2018-09-24 09:26:05 UTC
REVIEW: https://review.gluster.org/21254 (cluster/ec: Fix failure of tests/basic/ec/ec-1468261.t) posted (#1) for review on master by Ashish Pandey

Comment 3 Worker Ant 2018-09-25 13:58:25 UTC
COMMIT: https://review.gluster.org/21254 committed in master by "Xavi Hernandez" <xhernandez> with a commit message- cluster/ec: Fix failure of tests/basic/ec/ec-1468261.t

Problem:
In this test we are relying on eager-lock time
duration of 1 second to delay the post op + unlock phase
of an entry fop so that in this 1 second we can kill 2
bricks and dirty on directory could be set.

Solution:
To fix this issue, we should set the others.eager-lock
option to "ON" explicitly in the beginning of this test.

Change-Id: I19bbb9c15d7bdf96a96b20587c618192d0b740ef
fixes bz#1632161
Signed-off-by: Ashish Pandey <aspandey>

Comment 4 Shyamsundar 2019-03-25 16:30:59 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-6.0, please open a new bug report.

glusterfs-6.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2019-March/000120.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.