Bug 1651584

Summary: [geo-rep]: validate the config checkpoint date and fail if it is not is exact format hh:mm:ss
Product: [Community] GlusterFS Reporter: Shwetha K Acharya <sacharya>
Component: geo-replicationAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: mainlineCC: avishwan, bugs, csaba, khiremat, rhinduja, rhs-bugs, sacharya, storage-qa-internal
Target Milestone: ---Keywords: EasyFix, ZStream
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-6.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1429190 Environment:
Last Closed: 2019-03-25 16:32:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1429190, 1672979    
Bug Blocks:    

Comment 1 Worker Ant 2018-11-20 12:02:56 UTC
REVIEW: https://review.gluster.org/21692 (geo-rep: validate the config checkpoint date format) posted (#3) for review on master by Shwetha K Acharya

Comment 2 Kotresh HR 2018-11-21 03:40:01 UTC
Description of problem:
=======================

Currently the validation is upto 3 values but it does not validate further. Ideally anything which is not in exact format (Y-m-d H:M:S) should fail. 

[root@dhcp42-7 scripts]# gluster volume geo-replication master 10.70.43.249::slave config checkpoint 2017-03-05 15:30:45:10:11:12:13
geo-replication config updated successfully
[root@dhcp42-7 scripts]#
[root@dhcp42-7 scripts]# gluster volume geo-replication master 10.70.43.249::slave config checkpoint 2017-03-05 15:30:45:aa:bb:cc
geo-replication config updated successfully
[root@dhcp42-7 scripts]# 


Version-Release number of selected component (if applicable):
=============================================================
mainline


How reproducible:
=================

Always

Comment 3 Worker Ant 2018-11-22 04:58:37 UTC
REVIEW: https://review.gluster.org/21692 (geo-rep: validate the config checkpoint date format) posted (#6) for review on master by Kotresh HR

Comment 4 Shyamsundar 2019-03-25 16:32:04 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-6.0, please open a new bug report.

glusterfs-6.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://lists.gluster.org/pipermail/announce/2019-March/000120.html
[2] https://www.gluster.org/pipermail/gluster-users/