Bug 1429190 - [geo-rep]: validate the config checkpoint date and fail if it is not is exact format hh:mm:ss
Summary: [geo-rep]: validate the config checkpoint date and fail if it is not is exact...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: geo-replication
Version: rhgs-3.2
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
: RHGS 3.4.z Batch Update 4
Assignee: Shwetha K Acharya
QA Contact: Rochelle
URL:
Whiteboard:
: 1672979 (view as bug list)
Depends On:
Blocks: 1651584 1672979
TreeView+ depends on / blocked
 
Reported: 2017-03-05 13:28 UTC by Rahul Hinduja
Modified: 2019-03-27 03:43 UTC (History)
11 users (show)

Fixed In Version: glusterfs-3.12.2-41
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1651584 1672979 (view as bug list)
Environment:
Last Closed: 2019-03-27 03:43:36 UTC
Embargoed:


Attachments (Terms of Use)

Description Rahul Hinduja 2017-03-05 13:28:50 UTC
Description of problem:
=======================

Currently the validation is upto 3 values but it does not validate further. Ideally anything which is not in exact format (Y-m-d H:M:S) should fail. 

[root@dhcp42-7 scripts]# gluster volume geo-replication master 10.70.43.249::slave config checkpoint 2017-03-05 15:30:45:10:11:12:13
geo-replication config updated successfully
[root@dhcp42-7 scripts]#
[root@dhcp42-7 scripts]# gluster volume geo-replication master 10.70.43.249::slave config checkpoint 2017-03-05 15:30:45:aa:bb:cc
geo-replication config updated successfully
[root@dhcp42-7 scripts]# 


Version-Release number of selected component (if applicable):
=============================================================

glusterfs-geo-replication-3.8.4-17.el7rhgs.x86_64


How reproducible:
=================

Always

Comment 4 Aravinda VK 2018-02-06 08:08:50 UTC
Geo-replication support added to Glusterd2 project, which will be available with Gluster upstream 4.0 and 4.1 releases. 

Most of the issues already fixed with issue https://github.com/gluster/glusterd2/issues/271 and remaining fixes are noted in issue https://github.com/gluster/glusterd2/issues/557

We can close these issues since we are not planning any fixes for 3.x series.

Comment 6 Aravinda VK 2018-11-19 07:02:31 UTC
Fix required in `$SRC/cli/src/cli-cmd-parser.c`(handle error after strptime)

Comment 7 Shwetha K Acharya 2018-11-26 07:44:01 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=1651584

Comment 8 Shwetha K Acharya 2018-11-26 08:42:59 UTC
REVIEW: https://review.gluster.org/21692 (geo-rep: validate the config checkpoint date format)

Comment 12 Sunil Kumar Acharya 2019-02-07 08:24:26 UTC
*** Bug 1672979 has been marked as a duplicate of this bug. ***

Comment 20 errata-xmlrpc 2019-03-27 03:43:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0658


Note You need to log in before you can comment on or make changes to this bug.