Bug 165288

Summary: Review Request: libgdamm
Product: [Fedora] Fedora Reporter: Tom "spot" Callaway <tcallawa>
Component: Package ReviewAssignee: Michael Schwendt <bugs.michael>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://www.gtkmm.org
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-08-13 20:51:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 163779    
Description Flags
Updated Spec file none

Description Tom "spot" Callaway 2005-08-07 02:17:55 UTC
Spec Name or Url:

SRPM Name or Url: http://www.auroralinux.org/people/spot/review/libgdamm-1.3.7-1.src.rpm

Description: C++ wrappers for libgda. libgdamm is part of gnomemm - the C++
interface to the GTK+ GUI library.

This package was requested to help clear the path for glom. The spec is pretty typical for a gtk lib. 

Thanks in advance.

Comment 1 Michael Schwendt 2005-08-07 03:27:36 UTC
libgdamm-devel "Requires: glibmm24-devel" because of C++ header contents
and "Requires: libgda-devel" because of pkg-config file dependencies.

Generic INSTALL file in %doc is of no interest to package users.

README in %doc is 24 bytes and pretty much useless (unless you insist
on packaging it because it _may_ change in the future).

--enable-docs doesn't do anything.

Both package descriptions are confusing, IMHO. I don't think "libgdamm
is part of gnomemm" (=> libgnomemm26 in Extras). It is "part of a set of
powerful C++ bindings for the GNOME libraries, which provide additional 
functionality above GTK+/gtkmm".

In -devel summary and description I usually add the information that
"libraries" are included, too.

Comment 2 Tom "spot" Callaway 2005-08-11 15:55:58 UTC
Created attachment 117652 [details]
Updated Spec file

This updated spec makes the changes that you've pointed out. :)

Comment 3 Michael Schwendt 2005-08-11 16:47:21 UTC
Right. Approved.