Red Hat Bugzilla – Bug 165288
Review Request: libgdamm
Last modified: 2007-11-30 17:11:11 EST
Spec Name or Url: http://www.auroralinux.org/people/spot/review/libgdamm.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/libgdamm-1.3.7-1.src.rpm Description: C++ wrappers for libgda. libgdamm is part of gnomemm - the C++ interface to the GTK+ GUI library. This package was requested to help clear the path for glom. The spec is pretty typical for a gtk lib. Thanks in advance.
libgdamm-devel "Requires: glibmm24-devel" because of C++ header contents and "Requires: libgda-devel" because of pkg-config file dependencies. Generic INSTALL file in %doc is of no interest to package users. README in %doc is 24 bytes and pretty much useless (unless you insist on packaging it because it _may_ change in the future). --enable-docs doesn't do anything. Both package descriptions are confusing, IMHO. I don't think "libgdamm is part of gnomemm" (=> libgnomemm26 in Extras). It is "part of a set of powerful C++ bindings for the GNOME libraries, which provide additional functionality above GTK+/gtkmm". In -devel summary and description I usually add the information that "libraries" are included, too.
Created attachment 117652 [details] Updated Spec file This updated spec makes the changes that you've pointed out. :)
Right. Approved.