Bug 1653193

Summary:	Custom button on service UI `Display on Button` option not working
Product:	Red Hat CloudForms Management Engine	Reporter:	Nikhil Dhandre <ndhandre>
Component:	UI - Service	Assignee:	Martin Hradil <mhradil>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Nikhil Dhandre <ndhandre>
Severity:	high	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	high
Version:	5.9.6	CC:	bmidwood, dmetzger, jprause, lavenel, obarenbo, simaishi
Target Milestone:	GA	Keywords:	Regression, TestOnly, ZStream
Target Release:	5.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	custom_button
Fixed In Version:	5.10.0.28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1655772 (view as bug list)		Environment:
Last Closed:	2019-02-12 16:52:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1655772

Description Nikhil Dhandre 2018-11-26 08:17:17 UTC

Description of problem:
-----------------------
If `Display on Button option` not selected then the button should not show the text. OPS following this behavior but SSUI fails. Its showing text on a button. 


Version-Release number of selected component (if applicable):
--------------------------------------------------------------
Version 5.9.6.2.20181119175512_3a18916


How reproducible:
-----------------
Always

Steps to Reproduce:
------------------
1. Create a custom button on a Service object without selecting `Display on Button` option.
2. Check the MyService button with OPS UI. working fine except Icon. I think we already have a bug for this.
3. Check with SSUI. button `text` showing on the button. 

Actual results:
---------------
SSUI showing text on a button

Expected results:
------------------
SSUI button also allows the behavior of `Display on Button`


Additional info:
----------------
Attaching gif

Comment 4 Allen W 2018-11-28 15:27:32 UTC

Hi Nikhil!  Any chance we can get an ip of a system exhibiting this issue?

Comment 7 CFME Bot 2018-11-29 12:31:07 UTC

https://github.com/ManageIQ/manageiq-ui-service/pull/1506

Comment 8 CFME Bot 2018-11-29 13:06:11 UTC

New commit detected on ManageIQ/manageiq-ui-service/master:

https://github.com/ManageIQ/manageiq-ui-self_service/commit/e75b111885aa31bd23f7ef026ce3cae16e6c2ec4
commit e75b111885aa31bd23f7ef026ce3cae16e6c2ec4
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Nov 29 07:15:21 2018 -0500
Commit:     Martin Hradil <mhradil>
CommitDate: Thu Nov 29 07:15:21 2018 -0500

    Custom buttons - only show button name when the "Display on Button" option is set

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653193

 client/app/services/custom-button/custom-button.html | 8 +-
 1 file changed, 6 insertions(+), 2 deletions(-)

Comment 9 CFME Bot 2018-12-03 15:22:03 UTC

New commit detected on ManageIQ/manageiq-ui-service/hammer:

https://github.com/ManageIQ/manageiq-ui-service/commit/46d5e3fa70034eefec856232b2eb8830eb825ccf
commit 46d5e3fa70034eefec856232b2eb8830eb825ccf
Author:     Allen Wight <allen.b.wight>
AuthorDate: Thu Nov 29 08:02:13 2018 -0500
Commit:     Allen Wight <allen.b.wight>
CommitDate: Thu Nov 29 08:02:13 2018 -0500

    Merge pull request #1506 from himdel/bz1653193-custom-nodisplay

    BZ#1653193 - Custom buttons - only show button name when the "Display on Button" option is set

    (cherry picked from commit 71856b008316b30db734b620f729e2f3f5f0f8d7)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653193

 client/app/services/custom-button/custom-button.html | 8 +-
 1 file changed, 6 insertions(+), 2 deletions(-)

Comment 11 Nikhil Dhandre 2018-12-13 10:59:53 UTC

Working fine tested with Version 5.10.0.29.20181211195209_fd990a9