Description of problem: ----------------------- If `Display on Button option` not selected then the button should not show the text. OPS following this behavior but SSUI fails. Its showing text on a button. Version-Release number of selected component (if applicable): -------------------------------------------------------------- Version 5.9.6.2.20181119175512_3a18916 How reproducible: ----------------- Always Steps to Reproduce: ------------------ 1. Create a custom button on a Service object without selecting `Display on Button` option. 2. Check the MyService button with OPS UI. working fine except Icon. I think we already have a bug for this. 3. Check with SSUI. button `text` showing on the button. Actual results: --------------- SSUI showing text on a button Expected results: ------------------ SSUI button also allows the behavior of `Display on Button` Additional info: ---------------- Attaching gif
Hi Nikhil! Any chance we can get an ip of a system exhibiting this issue?
https://github.com/ManageIQ/manageiq-ui-service/pull/1506
New commit detected on ManageIQ/manageiq-ui-service/master: https://github.com/ManageIQ/manageiq-ui-self_service/commit/e75b111885aa31bd23f7ef026ce3cae16e6c2ec4 commit e75b111885aa31bd23f7ef026ce3cae16e6c2ec4 Author: Martin Hradil <mhradil> AuthorDate: Thu Nov 29 07:15:21 2018 -0500 Commit: Martin Hradil <mhradil> CommitDate: Thu Nov 29 07:15:21 2018 -0500 Custom buttons - only show button name when the "Display on Button" option is set Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653193 client/app/services/custom-button/custom-button.html | 8 +- 1 file changed, 6 insertions(+), 2 deletions(-)
New commit detected on ManageIQ/manageiq-ui-service/hammer: https://github.com/ManageIQ/manageiq-ui-service/commit/46d5e3fa70034eefec856232b2eb8830eb825ccf commit 46d5e3fa70034eefec856232b2eb8830eb825ccf Author: Allen Wight <allen.b.wight> AuthorDate: Thu Nov 29 08:02:13 2018 -0500 Commit: Allen Wight <allen.b.wight> CommitDate: Thu Nov 29 08:02:13 2018 -0500 Merge pull request #1506 from himdel/bz1653193-custom-nodisplay BZ#1653193 - Custom buttons - only show button name when the "Display on Button" option is set (cherry picked from commit 71856b008316b30db734b620f729e2f3f5f0f8d7) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1653193 client/app/services/custom-button/custom-button.html | 8 +- 1 file changed, 6 insertions(+), 2 deletions(-)
Working fine tested with Version 5.10.0.29.20181211195209_fd990a9