Bug 165489

Summary:	Review Request: airsnort - Wireless LAN (WLAN) tool which recovers encryption keys
Product:	[Fedora] Fedora	Reporter:	Andreas Bierfert <andreas.bierfert>
Component:	Package Review	Assignee:	Orion Poplawski <orion>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, orion
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://airsnort.shmoo.com/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-08-11 16:38:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Andreas Bierfert 2005-08-09 19:14:52 UTC

Spec Name or Url: http://fedora.lowlatency.de/review/airsnort.spec
SRPM Name or Url: http://fedora.lowlatency.de/review/airsnort-0.2.7e-3.src.rpm
Description: 
AirSnort is a wireless LAN (WLAN) tool which recovers encryption keys. 
AirSnort operates by passively monitoring transmissions, computing the
encryption key when enough packets have been gathered.

802.11b, using the Wired Equivalent Protocol (WEP), is crippled with numerous
security flaws. Most damning of these is the weakness described in " Weaknesses
in the Key Scheduling Algorithm of RC4 " by Scott Fluhrer, Itsik Mantin and Adi
Shamir. Adam Stubblefield was the first to implement this attack, but he has
not made his software public. AirSnort, along with WEPCrack, which was released
about the same time as AirSnort, are the first publicly available
implementaions of this attack.

AirSnort requires approximately 5-10 million encrypted packets to be gathered.
Once enough packets have been gathered, AirSnort can guess the encryption
password in under a second.

Comment 1 Orion Poplawski 2005-08-09 20:16:01 UTC

Still don't seem to be able to assign bugs to myself, not sure why.  Greg - can
you fix this?

Review:

Mostly looks quite good except for:

# rpmlint airsnort
W: airsnort no-version-in-last-changelog

changelog should be like:

* Thu Jun 02 2005 Andreas Bierfert <andreas.bierfert[AT]lowlatency.de> - 0.2.7e-3


Need:

BuildRequires: desktop-file-utils
or 
BuildRequires: /usr/bin/desktop-file-install

to build in mock.

Comment 2 Orion Poplawski 2005-08-09 20:18:11 UTC

Also, no icon has appeared in my KDE menu.  desktop file shows:

# cat /usr/share/applications/fedora-airsnort.desktop
[Desktop Entry]
Name=airsnort
Comment=Wireless LAN (WLAN) tool which recovers encryption keys
Exec=airsnort
Terminal=false
Type=Application
Encoding=UTF-8
Categories=Application;System;X-Fedora;
X-Desktop-File-Install-Version=0.10

Any ideas anyone?

Comment 3 Rex Dieter 2005-08-09 20:22:29 UTC

If you want/need an icon you need to specify one in the .desktop file:
Icon=app_foo_icon.png

Comment 4 Orion Poplawski 2005-08-09 20:26:50 UTC

Oops, I said Icon when I ment entry.  I just don't see it in any of my menus.

Comment 5 Rex Dieter 2005-08-09 20:31:32 UTC

You need a relevant entry in Categories.  For example, if the keyword "Network"
appears, it then goes in the Internet menu.  Where do you think it should go?

Comment 6 Orion Poplawski 2005-08-09 20:37:11 UTC

I would say "Internet" or possibly "System Tools".

Comment 7 Rex Dieter 2005-08-09 20:41:39 UTC

Then, add
--add-category "Network"
to the desktop-file-install command in the specfile and you should be good.

Comment 8 Andreas Bierfert 2005-08-09 23:36:28 UTC

Ok here you go: Fixed BR and .desktop file and added missing changelog version ...

http://fedora.lowlatency.de/review/airsnort.spec
http://fedora.lowlatency.de/review/airsnort-0.2.7e-4.src.rpm

Comment 9 Orion Poplawski 2005-08-10 23:16:26 UTC

I'm still not seeing a menu item, but this may just be a local thing.

Still see:

W: airsnort no-version-in-last-changelog


Formatting is messed up from wrapping.  End of line should be like:

<email> - 0.2.7e-4

All on one line, with a "-" separator.

Easily fixed, so Approved.

Comment 10 Andreas Bierfert 2005-08-11 00:02:07 UTC

Thanks... I will commit it asap...

As to the changelog: This has been talked about before and agreed to be ok in
this case because my name, mail combination is quiet long :)

Comment 11 Christian Iseli 2006-10-18 09:06:04 UTC

Normalize summary field for easy parsing