Spec Name or Url: http://fedora.lowlatency.de/review/airsnort.spec SRPM Name or Url: http://fedora.lowlatency.de/review/airsnort-0.2.7e-3.src.rpm Description: AirSnort is a wireless LAN (WLAN) tool which recovers encryption keys. AirSnort operates by passively monitoring transmissions, computing the encryption key when enough packets have been gathered. 802.11b, using the Wired Equivalent Protocol (WEP), is crippled with numerous security flaws. Most damning of these is the weakness described in " Weaknesses in the Key Scheduling Algorithm of RC4 " by Scott Fluhrer, Itsik Mantin and Adi Shamir. Adam Stubblefield was the first to implement this attack, but he has not made his software public. AirSnort, along with WEPCrack, which was released about the same time as AirSnort, are the first publicly available implementaions of this attack. AirSnort requires approximately 5-10 million encrypted packets to be gathered. Once enough packets have been gathered, AirSnort can guess the encryption password in under a second.
Still don't seem to be able to assign bugs to myself, not sure why. Greg - can you fix this? Review: Mostly looks quite good except for: # rpmlint airsnort W: airsnort no-version-in-last-changelog changelog should be like: * Thu Jun 02 2005 Andreas Bierfert <andreas.bierfert[AT]lowlatency.de> - 0.2.7e-3 Need: BuildRequires: desktop-file-utils or BuildRequires: /usr/bin/desktop-file-install to build in mock.
Also, no icon has appeared in my KDE menu. desktop file shows: # cat /usr/share/applications/fedora-airsnort.desktop [Desktop Entry] Name=airsnort Comment=Wireless LAN (WLAN) tool which recovers encryption keys Exec=airsnort Terminal=false Type=Application Encoding=UTF-8 Categories=Application;System;X-Fedora; X-Desktop-File-Install-Version=0.10 Any ideas anyone?
If you want/need an icon you need to specify one in the .desktop file: Icon=app_foo_icon.png
Oops, I said Icon when I ment entry. I just don't see it in any of my menus.
You need a relevant entry in Categories. For example, if the keyword "Network" appears, it then goes in the Internet menu. Where do you think it should go?
I would say "Internet" or possibly "System Tools".
Then, add --add-category "Network" to the desktop-file-install command in the specfile and you should be good.
Ok here you go: Fixed BR and .desktop file and added missing changelog version ... http://fedora.lowlatency.de/review/airsnort.spec http://fedora.lowlatency.de/review/airsnort-0.2.7e-4.src.rpm
I'm still not seeing a menu item, but this may just be a local thing. Still see: W: airsnort no-version-in-last-changelog Formatting is messed up from wrapping. End of line should be like: <email> - 0.2.7e-4 All on one line, with a "-" separator. Easily fixed, so Approved.
Thanks... I will commit it asap... As to the changelog: This has been talked about before and agreed to be ok in this case because my name, mail combination is quiet long :)
Normalize summary field for easy parsing